Changeset: b1deb90d2e37
Author:vromero
Date: 2013-02-08 09:15 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b1deb90d2e37
8005931: javac doesn't set ACC_STRICT for classes with package access
Reviewed-by: mcimadamore
!
Changeset: 017e8bdd440f
Author:vromero
Date: 2013-02-08 09:21 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/017e8bdd440f
7167125: Two variables after the same operation in a inner class return
different results
Reviewed-by: jjg, mcimadamore
!
Although I agree that the name: GSS_C_NO_CHANNEL_BINDINGS is misleading,
I can't identify anything else that seems more appropriate.
The header file:
/jdk8-tl/jdk/src/share/native/sun/security/jgss/wrapper/gssapi.h defines
GSS_C_NO_CHANNEL_BINDINGS as follows:
#define
Changeset: 79d7595abe95
Author:naoto
Date: 2013-02-08 09:35 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/79d7595abe95
8007038: ArrayIndexOutOfBoundsException on calling localizedDateTime().print()
with JapaneseChrono
Reviewed-by: okutsu
!
John,
Ideas?
It's a JNI so just throw OOM.
-Dmitry
On 2013-02-08 21:38, John Zavgren wrote:
Although I agree that the name: GSS_C_NO_CHANNEL_BINDINGS is misleading,
I can't identify anything else that seems more appropriate.
The header file:
Right, the important thing is to throw OOM to indicate the memory
allocation failure.
The return value won't matter. If the caller is a Java method, an OOM
will occur when returning from this JNI call. If the caller is another
JNI method, then the caller should check for pending error
John,
In this particular case we MUST distinguish between
(a) no channel bindings and basic context is all we have
and
(b) we can't process channel bindings for some reason.
-Dmitry
On 2013-02-08 23:01, Valerie (Yu-Ching) Peng wrote:
Right, the important thing is to throw OOM to indicate the
I think it's ok just to use NULL. An OOM is pretty self-explanatory.
Most if not all invocations that I recall seeing simply use NULL.
Valerie
On 02/08/13 12:00, John Zavgren wrote:
All:
I assume that anytime a JNI procedure in the native code experiences an OOM
(Out Of Memory) error, then
Valerie,
C is not distinguish between 0 and NULL.
In GSS case GSS_C_NO_CHANNEL_BINDINGS (expanded to 0) means that client
and server agreed that basic context is OK.
So return of GSS_C_NO_CHANNEL_BINDINGS(0) in OOM case could lead to
security issue if upper level doesn't check for exception.
I
It seems to me that this is a pretty common pattern. Would it make better
sense to define standard jni_malloc and jni_calloc functions that throw an OOM
if the underlying allocation fails and use those rather than having to add the
if statement check everywhere?
Mike
At 03:19 PM 2/8/2013,
The NULL in my earlier email is about the second argument for the OOM
error and not about the return code/value. As long as an OOM is thrown,
the return code/value won't be used. Since we must return a value per
JNI syntax even when OOM has been thrown, maybe we can just return -1,
or 0, or
Changeset: 522fb3867a3a
Author:darcy
Date: 2013-02-08 16:00 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/522fb3867a3a
8005623: Retrofit FunctionalInterface annotations to core platform interfaces
Reviewed-by: mduigou, chegar, alanb
!
Changeset: 60caf53b98e2
Author:jjg
Date: 2013-02-08 17:35 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/60caf53b98e2
8007610: javadoc doclint does not work with -private
Reviewed-by: darcy
! src/share/classes/com/sun/tools/javadoc/DocEnv.java
!
13 matches
Mail list logo
