hg: jdk8/tl/jdk: 8009638: Wrong comment for PL in LocaleISOData, 1989 forward Poland is Republic of Poland

2013-04-10 Thread yuka . kamiya
Changeset: 006a7a576fe9 Author:peytoia Date: 2013-04-11 12:22 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/006a7a576fe9 8009638: Wrong comment for PL in LocaleISOData, 1989 forward Poland is Republic of Poland Reviewed-by: okutsu ! src/share/classes/java/util/LocaleISODat

hg: jdk8/tl/jdk: 2 new changesets

2013-04-10 Thread weijun . wang
Changeset: 0ab22e58d151 Author:weijun Date: 2013-04-11 11:09 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0ab22e58d151 8011867: Accept unknown PKCS #9 attributes Reviewed-by: vinnie ! src/share/classes/sun/security/pkcs/PKCS9Attribute.java + test/sun/security/pkcs/pkcs9/Un

hg: jdk8/tl/jdk: 8005460: [findbugs] Probably returned array should be cloned

2013-04-10 Thread weijun . wang
Changeset: 6f8e1428f7c3 Author:weijun Date: 2013-04-11 10:58 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6f8e1428f7c3 8005460: [findbugs] Probably returned array should be cloned Reviewed-by: xuelei ! src/share/classes/sun/security/krb5/PrincipalName.java + test/sun/secur

Code review request: 8009636: JARSigner including TimeStamp PolicyID (TSAPolicyID) as defined in RFC3161

2013-04-10 Thread Weijun Wang
Hi Sean Please review the code changes http://cr.openjdk.java.net/~weijun/8009636/webrev.00/ Here I add a new -tsapolicycd option to jarsigner and pass the value all the way down to TSRequest. A new check inside PKCS7::generateTimestampToken is added to confirm the responded policyID is i

hg: jdk8/tl/jdk: 8011930: Long.parseLong(String, int) has inaccurate limit on radix for using 'L'

2013-04-10 Thread joe . darcy
Changeset: b0458dd21ba6 Author:darcy Date: 2013-04-10 16:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b0458dd21ba6 8011930: Long.parseLong(String, int) has inaccurate limit on radix for using 'L' Reviewed-by: smarks ! src/share/classes/java/lang/Long.java

Update #6: JEP 123: SecureRandom Draft and Implementation.

2013-04-10 Thread Brad Wetmore
Fixed some stupidness in the tests. http://cr.openjdk.java.net/~wetmore/6425477/webrev.06/ Also, ignore the make/sun/splashscreen change. That will be fixed elsewhere, but I needed it to be able to build using the old system. Brad On 4/10/2013 3:07 PM, Brad Wetmore wrote: Hi Florian,

hg: jdk8/tl/jdk: 8010948: Add conversion functional interfaces

2013-04-10 Thread mike . duigou
Changeset: 863da64214e8 Author:mduigou Date: 2013-04-10 14:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/863da64214e8 8010948: Add conversion functional interfaces Reviewed-by: mduigou, dholmes Contributed-by: Brian Goetz + src/share/classes/java/util/function/DoubleToI

Re: Update #5: JEP 123: SecureRandom Draft and Implementation.

2013-04-10 Thread Brad Wetmore
Hi Florian, > I wonder if this change to src/share/lib/security/java.security-linux > > -securerandom.source=file:/dev/urandom > +securerandom.source=file:/dev/random > > causes the return of the blocking behavior. Welcome to my "can of worms." [1] I hope everything I've said below is correct,

Re: Code review request: 8011867 and 8011745, pkcs data types

2013-04-10 Thread Christophe Ravel
There is no version information for either bug (no affects version/s, no fix version/s). Are you fixing these for JDK 8 ? The bug status should be "In progress" Weijun Wang April 10, 2013 7:06 AM 8011745: Unknown CertificateChoices    http://cr.openjdk.java.net/~weijun/

Re: Code review request: 8011867 and 8011745, pkcs data types

2013-04-10 Thread Vincent Ryan
Both fixes look good. On 10 Apr 2013, at 15:06, Weijun Wang wrote: > 8011745: Unknown CertificateChoices > > http://cr.openjdk.java.net/~weijun/8011745/webrev.00/ > > 8011867: Accept unknown PKCS #9 attributes > > http://cr.openjdk.java.net/~weijun/8011867/webrev.00/ > > Thanks > Max

Re: Update #5: JEP 123: SecureRandom Draft and Implementation.

2013-04-10 Thread Florian Weimer
On 04/10/2013 09:17 AM, Brad Wetmore wrote: Hi Xuelei/Weijun, Thanks for the comments. The version I plan to putback is: http://cr.openjdk.java.net/~wetmore/6425477/webrev.05/ I wonder if this change to src/share/lib/security/java.security-linux -securerandom.source=file:/dev/urandom +

Code review request: 8011867 and 8011745, pkcs data types

2013-04-10 Thread Weijun Wang
8011745: Unknown CertificateChoices http://cr.openjdk.java.net/~weijun/8011745/webrev.00/ 8011867: Accept unknown PKCS #9 attributes http://cr.openjdk.java.net/~weijun/8011867/webrev.00/ Thanks Max

Re: Update #5: JEP 123: SecureRandom Draft and Implementation.

2013-04-10 Thread Xuelei Fan
Looks fine to me. Thanks for take the comments. Xuelei On 4/10/2013 3:17 PM, Brad Wetmore wrote: > Hi Xuelei/Weijun, > > Thanks for the comments. > > The version I plan to putback is: > > http://cr.openjdk.java.net/~wetmore/6425477/webrev.05/ > > I probably won't have time to take any fu

hg: jdk8/tl/langtools: 8011432: javac, compiler regression iterable + captured type

2013-04-10 Thread vicente . romero
Changeset: a4be2c2fe0a1 Author:vromero Date: 2013-04-10 12:31 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a4be2c2fe0a1 8011432: javac, compiler regression iterable + captured type Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! tes

Update #5: JEP 123: SecureRandom Draft and Implementation.

2013-04-10 Thread Brad Wetmore
Hi Xuelei/Weijun, Thanks for the comments. The version I plan to putback is: http://cr.openjdk.java.net/~wetmore/6425477/webrev.05/ I probably won't have time to take any further comments before vacation, but can address things when I'm back. I have a few more from Bernd that I'd like t