Re: Code Review Request for 7196009

2013-04-22 Thread Matthew Hall
Perhaps it points toward adding an enhanced Properties class which contains additional features useful for configuration files, such as the missing ones you mentioned. Then everyone could benefit from it, instead of it being private to the PKCS11 code only. Matthew. On Mon, Apr 22, 2013 at 05:

Re: Code Review Request for 7196009

2013-04-22 Thread Valerie (Yu-Ching) Peng
The concurrent config parsing impl in SunPKCS11 provider may seem more complicated than necessary at the first sight. However, it has several advantages: this strict parsing can detect invalid settings right at parsing time and fail if any error is detected. Special handling for different keys

Re: Code Review Request for 7196009

2013-04-22 Thread Weijun Wang
No more comment. Thanks Max On 4/23/13 7:28 AM, Valerie (Yu-Ching) Peng wrote: > > Yes, I think the original impl which uses parseLine() to process the > path values is incorrect since whatever specified should be preserved as > a whole. > > Currently, the parseLine() is only used for parsing d

Re: Code Review Request for 7196009

2013-04-22 Thread Valerie (Yu-Ching) Peng
Yes, I think the original impl which uses parseLine() to process the path values is incorrect since whatever specified should be preserved as a whole. Currently, the parseLine() is only used for parsing descriptions. The description line cannot contain special characters, otherwise an exception w

Code review: 8001284 & 8012971

2013-04-22 Thread Anthony Scarpino
This code review is for the following two bugs: - 8001284 Buffer problems with SunPKCS11-Solaris and CKM_AES_CTR - 8012971 PKCS11Test hiding exception failures The first fix is simple as it prevents the method from enforcing AES block lengths on CTR, a stream cipher. The second fix is a test p

hg: jdk8/tl/jdk: 8010666: Implement Currency/LocaleNameProvider in Windows Host LocaleProviderAdapter

2013-04-22 Thread naoto . sato
Changeset: 62fb9e2b5da1 Author:naoto Date: 2013-04-22 13:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/62fb9e2b5da1 8010666: Implement Currency/LocaleNameProvider in Windows Host LocaleProviderAdapter Reviewed-by: okutsu ! src/macosx/classes/sun/util/locale/provider/Hos

hg: jdk8/tl/nashorn: 9 new changesets

2013-04-22 Thread sundararajan . athijegannathan
Changeset: ac309d492b8d Author:sundar Date: 2013-04-18 15:50 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ac309d492b8d 8012462: Date.prototype.toJSON does not handle non-Date 'this' as per the spec. Reviewed-by: jlaskey, hannesw ! src/jdk/nashorn/internal/objects/Nativ

hg: jdk8/tl/langtools: 8011027: Type parameter annotations not passed through to javax.lang.model

2013-04-22 Thread joel . franck
Changeset: bae8387d16aa Author:jfranck Date: 2013-04-22 10:24 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bae8387d16aa 8011027: Type parameter annotations not passed through to javax.lang.model Reviewed-by: jjg, darcy ! src/share/classes/com/sun/tools/javac/code/Sym

hg: jdk8/tl/jdk: 3 new changesets

2013-04-22 Thread mike . duigou
Changeset: 3ca33647db95 Author:akhil Date: 2013-04-22 09:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3ca33647db95 8001647: default methods for Collections - forEach, removeIf, replaceAll, sort Reviewed-by: alanb, dholmes, mduigou, psandoz, smarks Contributed-by: Akhil A