hg: jdk8/tl/jdk: 8017453: ReplayCache tests fail on multiple platforms

2013-06-24 Thread weijun . wang
Changeset: 1bf060029a5d Author:weijun Date: 2013-06-24 16:25 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1bf060029a5d 8017453: ReplayCache tests fail on multiple platforms Reviewed-by: xuelei ! test/sun/security/krb5/auto/ReplayCacheExpunge.java !

hg: jdk8/tl/jdk: 8017477: Remove TimeZone.DisplayNames, no longer used

2013-06-24 Thread alan . bateman
Changeset: 5f80b8cee601 Author:alanb Date: 2013-06-24 11:26 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5f80b8cee601 8017477: Remove TimeZone.DisplayNames, no longer used Reviewed-by: okutsu ! src/share/classes/java/util/TimeZone.java

Re: [7u] code review request: 8014805: NPE is thrown during certpath validation if certificate does not have AuthorityKeyIdentifier extension

2013-06-24 Thread Vincent Ryan
Thanks. On 22 Jun 2013, at 01:19, Xuelei Fan wrote: Looks fine to me. Xuelei On 6/21/2013 11:46 PM, Vincent Ryan wrote: Please review this fix for 7u: http://cr.openjdk.java.net/~vinnie/8014805/webrev.00/ http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014805 It corrects the

Re: [7u] code review request: 8014805: NPE is thrown during certpath validation if certificate does not have AuthorityKeyIdentifier extension

2013-06-24 Thread Vincent Ryan
Hello all, The fix to handle Authority Key IDs also applies to Subject Key IDs so I've duplicated the changes: http://cr.openjdk.java.net/~vinnie/8014805/webrev.01 Thanks. On 24 Jun 2013, at 12:42, Vincent Ryan wrote: Thanks. On 22 Jun 2013, at 01:19, Xuelei Fan wrote: Looks fine to

Re: [7u] code review request: 8014805: NPE is thrown during certpath validation if certificate does not have AuthorityKeyIdentifier extension

2013-06-24 Thread Sean Mullan
On 06/24/2013 10:38 AM, Vincent Ryan wrote: Hello all, The fix to handle Authority Key IDs also applies to Subject Key IDs so I've duplicated the changes: http://cr.openjdk.java.net/~vinnie/8014805/webrev.01 1211 subjectKeyId = id.getIdentifier(); Should id be

Re: 8017325, 8017326: Cleanup of javadoc code tag

2013-06-24 Thread Joe Darcy
Hi Jason, On 6/21/2013 6:58 PM, Jason Uh wrote: After learning that javadoc is now capable of properly formatting the pre{@code ...}/pre construct, I have updated the changeset for java.security.cert. Please review instead: Webrevs -- - java.security.cert (updated):

Re: [7u] code review request: 8014805: NPE is thrown during certpath validation if certificate does not have AuthorityKeyIdentifier extension

2013-06-24 Thread Vincent Ryan
I've updated the webrev to address your comments: http://cr.openjdk.java.net/~vinnie/8014805/webrev.02/ Thanks. On 24 Jun 2013, at 16:24, Sean Mullan wrote: On 06/24/2013 10:38 AM, Vincent Ryan wrote: Hello all, The fix to handle Authority Key IDs also applies to Subject Key IDs so I've

code review request: 8012971 PKCS11Test hiding exception failures

2013-06-24 Thread Anthony Scarpino
I need a code review for some test changes. They include the follow bugs: JDK-8012971 PKCS11Test hiding exception failures JDK-7193793 sun/security/pkcs11/ec/TestECDH.java failing intermittently JDK-7198198 sun/security/pkcs11/ec/ReadCertificates.java fails on Suse Linux A significant change is

Re: [7u] code review request: 8014805: NPE is thrown during certpath validation if certificate does not have AuthorityKeyIdentifier extension

2013-06-24 Thread Sean Mullan
Looks good. --Sean On 06/24/2013 02:33 PM, Vincent Ryan wrote: I've updated the webrev to address your comments: http://cr.openjdk.java.net/~vinnie/8014805/webrev.02/ Thanks. On 24 Jun 2013, at 16:24, Sean Mullan wrote: On 06/24/2013 10:38 AM, Vincent Ryan wrote: Hello all, The fix

Review Request 8007035: Deprecate SecurityManager.checkMemberAccess

2013-06-24 Thread Mandy Chung
I have updated the fix per the discussion in [1]. SecurityManager.checkMemberAccess will be deprecated and will check for AllPermission in a future release. Webrev at: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8007035/webrev.01/ Specdiff:

Re: 8017325, 8017326: Cleanup of javadoc code tag

2013-06-24 Thread Jason Uh
On 6/24/13 10:51 AM, Joe Darcy wrote: Hi Jason, On 6/21/2013 6:58 PM, Jason Uh wrote: After learning that javadoc is now capable of properly formatting the pre{@code ...}/pre construct, I have updated the changeset for java.security.cert. Please review instead: Webrevs -- -

hg: jdk8/tl/jdk: 8017468: typo in javadoc: ResourceBunlde

2013-06-24 Thread naoto . sato
Changeset: bb2e67628dc0 Author:naoto Date: 2013-06-24 16:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bb2e67628dc0 8017468: typo in javadoc: ResourceBunlde Reviewed-by: okutsu ! src/share/classes/java/util/spi/LocaleServiceProvider.java

Re: 8017325, 8017326: Cleanup of javadoc code tag

2013-06-24 Thread Joseph Darcy
On 6/24/2013 3:00 PM, Jason Uh wrote: On 6/24/13 10:51 AM, Joe Darcy wrote: Hi Jason, On 6/21/2013 6:58 PM, Jason Uh wrote: After learning that javadoc is now capable of properly formatting the pre{@code ...}/pre construct, I have updated the changeset for java.security.cert. Please review

Re: Code Review Request for 7196805: DH Key interoperability testing between SunJCE and JsafeJCE not successful

2013-06-24 Thread Weijun Wang
Code change looks fine. No regression test? --Max On 6/20/13 4:45 AM, Valerie (Yu-Ching) Peng wrote: I have updated the webrev to address your comments: http://cr.openjdk.java.net/~valeriep/7196805/webrev.01/ As for using JDK 8 default method feature, I think maybe it's better to delay the

hg: jdk8/tl/jdk: 6469160: (fmt) general (%g) formatting of zero (0.0) with precision 0 or 1 throws ArrayOutOfBoundsException

2013-06-24 Thread dan . xu
Changeset: eabcb85fcabc Author:bpb Date: 2013-06-24 14:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eabcb85fcabc 6469160: (fmt) general (%g) formatting of zero (0.0) with precision 0 or 1 throws ArrayOutOfBoundsException Summary: For zero value ensure than an unpadded

Code review request: 8016051: Possible ClassCastException in KdcComm

2013-06-24 Thread Artem Smotrakov
Hi, please review this fix for 8: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8016051 http://1.smotrakov.z8.ru/8016051/webrev.00/ It fixes a possible ClassCastException if an exception thrown from send() method is not IOException or KrbException. The first exception is thrown if all

Mac awt regression? (was JDK-8017189: [macosx]Step9: After openning the File menu, the items are disabled; regression since b94)

2013-06-24 Thread Weijun Wang
Hi All Sorry to write in HTML. I need to add a table. The bug is about after several clicks on policytool a menu item is disabled. I've simplified the tool to a small program (attached) with the same behavior. Running the program in JDK 7 and 8 on Mac shows these differences: JDK 7