Sure I'll break it up if that's easier and someone will review it.
thanks
Tony
On 07/10/2013 06:07 PM, Valerie (Yu-Ching) Peng wrote:
Tony,
Did someone review this yet?
Since there are 3 bug fixes, can you separate them out into 3 webrevs?
I believe that has been the convention to have one w
On 07/10/2013 06:10 PM, Valerie (Yu-Ching) Peng wrote:
Anyone has one minute to review this trivial and straight forward fix to
existing PKCS11 regression test?
8020321: Problem in PKCS11 regression test TestRSAKeyLength
webrev: http://cr.openjdk.java.net/~valeriep/8020321/webrev.00/
Thanks,
V
> http://cr.openjdk.java.net/~valeriep/7196382/webrev.02/
This is the latest webrev. ;-)
Looks fine to me.
Xuelei
On 7/11/2013 10:25 AM, Xuelei Fan wrote:
> Ooops, please ignore this mail. I went into the wrong webrev.
>
> Xuelei
>
> On 7/11/2013 10:23 AM, Xuelei Fan wrote:
>> src/share/clas
Ooops, please ignore this mail. I went into the wrong webrev.
Xuelei
On 7/11/2013 10:23 AM, Xuelei Fan wrote:
> src/share/classes/sun/security/pkcs11/P11KeyPairGenerator.java
> ==
>
> It is instinctive and easy to maintain to c
src/share/classes/sun/security/pkcs11/P11KeyPairGenerator.java
==
It is instinctive and easy to maintain to code if we have the comment:
+// RSA, DH, and DSA
104 keySize = 1024;
I'm not sure, just a double
Need to make sure this won't happen again by adding a check.
Thanks for another quick review,
Valerie
On 07/10/13 18:30, Xuelei Fan wrote:
Wow, you are so careful about the hard-coded arrays. Looks fine.
Xuelei
On 7/11/2013 9:10 AM, Valerie (Yu-Ching) Peng wrote:
Anyone has one minute to re
Wow, you are so careful about the hard-coded arrays. Looks fine.
Xuelei
On 7/11/2013 9:10 AM, Valerie (Yu-Ching) Peng wrote:
>
> Anyone has one minute to review this trivial and straight forward fix to
> existing PKCS11 regression test?
>
> 8020321: Problem in PKCS11 regression test TestRSAKey
Looks fine.
Xuelei
On 7/11/2013 7:04 AM, Valerie (Yu-Ching) Peng wrote:
> While working w/ Dave for a JCE provider build, I ran into a build
> failure due to a javac change, i.e. 6356530 " -Xlint:serial does not
> flag abstract classes with concrete methods/members". The new-infra
> build does n
Anyone has one minute to review this trivial and straight forward fix to
existing PKCS11 regression test?
8020321: Problem in PKCS11 regression test TestRSAKeyLength
webrev: http://cr.openjdk.java.net/~valeriep/8020321/webrev.00/
Thanks,
Valerie
Tony,
Did someone review this yet?
Since there are 3 bug fixes, can you separate them out into 3 webrevs?
I believe that has been the convention to have one webrev corresponding
to one bug.
Otherwise, things can get confusing for both reviewers as well as
sustaining if later they tried to back
Changeset: 702556f7977e
Author:juh
Date: 2013-07-10 18:01 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/702556f7977e
8020318: Fix doclint issues in java.net
Reviewed-by: darcy, khazra
! src/share/classes/java/net/CookieStore.java
! src/share/classes/java/net/HttpURLPermissi
While working w/ Dave for a JCE provider build, I ran into a build
failure due to a javac change, i.e. 6356530 " -Xlint:serial does not
flag abstract classes with concrete methods/members". The new-infra
build does not have this problem, only the old build does.
Here is the bug id and its web
Changeset: 69d9fe8175a0
Author:sspitsyn
Date: 2013-07-10 14:20 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/69d9fe8175a0
8020308: Fix doclint issues in java.lang.management
Reviewed-by: darcy
Contributed-by: serguei.spit...@oracle.com
! src/share/classes/java/lang/manageme
Changeset: 607fa1ff3de2
Author:bpb
Date: 2013-07-09 11:26 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/607fa1ff3de2
6178739: (fmt) Formatter.format("%0.4f\n", 56789.456789) generates
MissingFormatWidthException
Summary: Change the field width specification to require a pos
Changeset: 7c44ea602cc8
Author:darcy
Date: 2013-07-10 11:05 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7c44ea602cc8
8020294: Fix doclint issues in java.util.Spliterator
Reviewed-by: psandoz
! src/share/classes/java/util/Spliterator.java
Looks fine too.
--Sean
On 07/10/2013 03:42 AM, Weijun Wang wrote:
Hi Sean
Can you take a look at the webrev for jdk7u-dev. The only difference is
that in 7u there is no check for output == null at all so an NPE is thrown.
http://cr.openjdk.java.net/~weijun/8019267/7u-dev/webrev.00/
Thank
Changeset: 882baa1e0a38
Author:psandoz
Date: 2013-07-10 10:24 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/882baa1e0a38
8020040: Improve and generalize the F/J tasks to handle right or left-balanced
trees
Reviewed-by: briangoetz
Contributed-by: doug lea , paul sandoz
!
Changeset: ff5df05222d1
Author:psandoz
Date: 2013-07-10 09:52 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ff5df05222d1
8017447: Unmodifiable map entry becomes modifiable if taken from a stream of
map entries
Reviewed-by: briangoetz
! src/share/classes/java/util/Collectio
Hi Sean
Can you take a look at the webrev for jdk7u-dev. The only difference is
that in 7u there is no check for output == null at all so an NPE is thrown.
http://cr.openjdk.java.net/~weijun/8019267/7u-dev/webrev.00/
Thanks
Max
On 7/9/13 8:16 PM, Sean Mullan wrote:
Looks fine.
--Sean
O
Changeset: 780a64979c8d
Author:weijun
Date: 2013-07-10 15:11 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/780a64979c8d
8019267: NPE in AbstractSaslImpl when trace level >= FINER in KRB5
Reviewed-by: mullan
! src/share/classes/com/sun/security/sasl/util/AbstractSaslImpl.jav
20 matches
Mail list logo
