hg: jdk8/tl/langtools: 8024096: some javadoc tests may contain false positive results

2013-09-18 Thread bhavesh . x . patel
Changeset: 8df12c315ea3 Author:bpatel Date: 2013-09-18 22:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8df12c315ea3 8024096: some javadoc tests may contain false positive results Reviewed-by: jjg ! test/com/sun/javadoc/lib/JavadocTester.java ! test/com/sun/javadoc

hg: jdk8/tl/langtools: 8015249: javadoc fails to document static final fields in annotation types

2013-09-18 Thread bhavesh . x . patel
Changeset: a2a5ad0853ed Author:bpatel Date: 2013-09-18 17:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a2a5ad0853ed 8015249: javadoc fails to document static final fields in annotation types Reviewed-by: jjg + src/share/classes/com/sun/tools/doclets/formats/html/

Re: [8] Request for review: 8008296: keytool utility doesn't support '-importpassword' command

2013-09-18 Thread Weijun Wang
Hi Vinnie Mostly good, but do you need to add a help line for it? You reuse the GENSECKEY command so "keytool -importpass -help" looks strange. Also, the command name is -importpassword but the prompt is "Enter the passphrase to be stored". Feel a little uncomfortable. Thanks Max On 9/14/

hg: jdk8/tl/jdk: 8023954: MBean*Info.equals: throw NPE

2013-09-18 Thread shanliang . jiang
Changeset: 8708569b5524 Author:sjiang Date: 2013-09-18 08:51 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8708569b5524 8023954: MBean*Info.equals: throw NPE Reviewed-by: dfuchs, dholmes ! src/share/classes/javax/management/MBeanAttributeInfo.java ! src/share/classes/javax/

hg: jdk8/tl/jdk: 8015762: TEST_BUG: java/nio/channels/DatagramChannel/AdaptDatagramSocket.java failing intermittently [win]

2013-09-18 Thread chris . hegarty
Changeset: b3a506a30fda Author:ewang Date: 2013-09-18 15:13 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b3a506a30fda 8015762: TEST_BUG: java/nio/channels/DatagramChannel/AdaptDatagramSocket.java failing intermittently [win] Reviewed-by: chegar, alanb ! test/java/nio/chan

hg: jdk8/tl/nashorn: 2 new changesets

2013-09-18 Thread sundararajan . athijegannathan
Changeset: 1971c2d770ae Author:sundar Date: 2013-09-18 13:06 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1971c2d770ae 8024972: for (LeftHandSideExpression in Expression) crashes the compiler Reviewed-by: lagergren, hannesw ! src/jdk/nashorn/internal/codegen/CodeGenera

Re: webrev.01 of 8011402: Move blacklisting certificate logic from hard code to data

2013-09-18 Thread Sean Mullan
On 09/18/2013 09:32 AM, Weijun Wang wrote: On 9/18/13 9:20 PM, Sean Mullan wrote: I think it may be worth adding (maybe not for JDK 8 but JDK 9) a new method to the Certificate class called getFingerPrint(String alg) ... This way the fingerprint would not have to be calculated every time when

Code review request: 8012615: backport of capaths fix to 7u60

2013-09-18 Thread Weijun Wang
Hi Valerie I've backported 8012615 to 7u60. Please take a review http://cr.openjdk.java.net/~weijun/8012615/7u-dev/webrev.00/ Changes include: 1. Direct copy of parseCapaths and parseHierarchy from jdk8, except for a) use old Config methods b) parseCapaths returns null instead of thro

hg: jdk8/tl/jdk: 8011402: Move blacklisting certificate logic from hard code to data

2013-09-18 Thread weijun . wang
Changeset: 07d73060e0da Author:weijun Date: 2013-09-18 21:37 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/07d73060e0da 8011402: Move blacklisting certificate logic from hard code to data Reviewed-by: erikj, mullan ! make/java/security/Makefile ! makefiles/CopyFiles.gmk ! s

Re: webrev.01 of 8011402: Move blacklisting certificate logic from hard code to data

2013-09-18 Thread Weijun Wang
On 9/18/13 9:20 PM, Sean Mullan wrote: I think it may be worth adding (maybe not for JDK 8 but JDK 9) a new method to the Certificate class called getFingerPrint(String alg) ... This way the fingerprint would not have to be calculated every time when using 3rd party providers for CertificateFac

hg: jdk8/tl/langtools: 8024127: javac, Code_attribute.exception_table_langth should be Code_attribute.exception_table_length

2013-09-18 Thread joel . franck
Changeset: ac6ec071c2b2 Author:alundblad Date: 2013-09-18 14:39 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ac6ec071c2b2 8024127: javac, Code_attribute.exception_table_langth should be Code_attribute.exception_table_length Summary: exception_table_langth renamed to

Re: webrev.01 of 8011402: Move blacklisting certificate logic from hard code to data

2013-09-18 Thread Sean Mullan
On 09/17/2013 07:07 AM, Weijun Wang wrote: Webrev updated to version 02 at http://cr.openjdk.java.net/~weijun/8011402/webrev.02/ Changes since webrev.01: 1. Makefiles: - new build logic outside "ifndef OPENJDK" - Add a sed check to make sure open and close list use same algorithm 2

hg: jdk8/tl/jdk: 8024883: (se) SelectableChannel.register throws NPE if fd >= 64k (lnx)

2013-09-18 Thread alan . bateman
Changeset: e92635d6834c Author:alanb Date: 2013-09-18 14:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e92635d6834c 8024883: (se) SelectableChannel.register throws NPE if fd >= 64k (lnx) Reviewed-by: alanb, coffeys Contributed-by: nmau...@redhat.com, alan.bate...@oracle.c

hg: jdk8/tl/jdk: 8012615: Realm.getRealmsList returns realms list in wrong

2013-09-18 Thread weijun . wang
Changeset: ee8b292ee568 Author:weijun Date: 2013-09-18 18:22 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ee8b292ee568 8012615: Realm.getRealmsList returns realms list in wrong Reviewed-by: valeriep, xuelei ! src/share/classes/sun/security/krb5/Config.java ! src/share/clas

Re: webrev.01 of 8011402: Move blacklisting certificate logic from hard code to data

2013-09-18 Thread Erik Joelsson
Build change looks ok. /Erik On 2013-09-17 13:07, Weijun Wang wrote: Webrev updated to version 02 at http://cr.openjdk.java.net/~weijun/8011402/webrev.02/ Changes since webrev.01: 1. Makefiles: - new build logic outside "ifndef OPENJDK" - Add a sed check to make sure open and close l