Re: RFR: 8031588 warnings from b03 for jdk/src/share/native/sun/security/jgss/wrapper: JNI exception pending

2014-02-06 Thread Sean Mullan
Looks fine to me, Michael. Please add a noreg label to the bug. --Sean On 02/06/2014 04:57 AM, Michael McMahon wrote: Hi, This is a fix adding some checks for pending exceptions in the JGSS native code. All of these cases could only practically happen in case of OutOfMemoryError. There are a c

hg: jdk8/tl/jdk: 8033590: java.util.Comparator::thenComparing has unnecessary type restriction

2014-02-06 Thread henry . jen
Changeset: 7534523b4174 Author:henryjen Date: 2014-02-06 10:30 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7534523b4174 8033590: java.util.Comparator::thenComparing has unnecessary type restriction Reviewed-by: psandoz ! src/share/classes/java/util/Comparator.java ! test/

Re: [9] RFR 8033757: Redo JDK-8011983 (due to bad merge with JDK-8031586)

2014-02-06 Thread Alan Bateman
On 06/02/2014 11:17, Vincent Ryan wrote: My fix for JDK-8011983 trampled on the fix for JDK-8031568 in: jdk/src/windows/native/com/sun/security/auth/module/nt.c This change merges both of those changes. Webrev: http://cr.openjdk.java.net/~vinnie/8033757/webrev.00/

[9] RFR 8033757: Redo JDK-8011983 (due to bad merge with JDK-8031586)

2014-02-06 Thread Vincent Ryan
My fix for JDK-8011983 trampled on the fix for JDK-8031568 in: jdk/src/windows/native/com/sun/security/auth/module/nt.c This change merges both of those changes. Webrev: http://cr.openjdk.java.net/~vinnie/8033757/webrev.00/ Thanks.

RFR: 8031588 warnings from b03 for jdk/src/share/native/sun/security/jgss/wrapper: JNI exception pending

2014-02-06 Thread Michael McMahon
Hi, This is a fix adding some checks for pending exceptions in the JGSS native code. All of these cases could only practically happen in case of OutOfMemoryError. There are a couple of places where the JNI spec isn't completely clear whether the exception will be thrown. In those cases, we che