Re: RFR 8033271: Manual security tests have @ignore rather than @run main/manual

2014-03-14 Thread Xuelei Fan
Minimal comments: test/sun/security/smartcardio/TestAll.java == Looks like there is no actual update. test/sun/security/smartcardio/* === - 32 //This test requires special hardware. + 32 // This test requires special hardware.

Re: RFR 8033271: Manual security tests have @ignore rather than @run main/manual

2014-03-14 Thread Rajan Halade
Thanks Xuelei for your comment. I updated all tests as per your suggestion - http://cr.openjdk.java.net/~wetmore/8033271/webrev.02/ Please review again. Thanks, Rajan On 3/14/2014 16:39, Xuelei Fan wrote: I like the changes. I'm afraid the lines following the @summary tag will be joined into o

Re: RFR 8033271: Manual security tests have @ignore rather than @run main/manual

2014-03-14 Thread Xuelei Fan
I like the changes. I'm afraid the lines following the @summary tag will be joined into one line during testing. We had such bad experiences in a lot JSSE tests. Would you like put the manual testing comment into a separated commend block? For example, change the update * @summary Ensure auth

Code Review Request: 8031003: [Parfait] warnings from jdk/src/share/native/sun/security/jgss/wrapper: JNI exception pending

2014-03-14 Thread Valerie (Yu-Ching) Peng
Max, Can you please help reviewing the fix for 8031003: [Parfait] warnings from jdk/src/share/native/sun/security/jgss/wrapper: JNI exception pending? I ended up re-factoring the code to clean things up. So, the changes are somewhat extensive. I have also replaced the debug callbacks with nat

RFR 8033271: Manual security tests have @ignore rather than @run main/manual

2014-03-14 Thread Rajan Halade
Please review this fix: http://cr.openjdk.java.net/~wetmore/8033271/webrev.01/ I removed @ignore from all these tests and marked them with manual for now. These tests will be considered for automation as a separate effort and will be executed manually for now. Thanks, Rajan