Re: RFR 8039853: Provider.Service.newInstance() does not work with current JDK JGSS Mechanisms

2014-04-15 Thread Sean Mullan
Looks fine to me. --Sean On 04/15/2014 04:03 AM, Wang Weijun wrote: Please review the code changes at http://cr.openjdk.java.net/~weijun/8039853/webrev.00/ If you find it confused, I have mistakenly pushed some code changes in http://hg.openjdk.java.net/jdk9/dev/jdk/rev/ba6e2fcdfa15 a

[9] Review Request: 8040260 Tidy warnings cleanup for javax.crypto, javax.net

2014-04-15 Thread alexander stepanov
Hello, Could you please review the fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-8040260 Webrev corresponding: http://cr.openjdk.java.net/~yan/8040260/webrev.00/ Just a very minor cleanup of javadoc to avoid tidy warnings; no other code affected. Thanks. Regards, Alexa

RFR 8039853: Provider.Service.newInstance() does not work with current JDK JGSS Mechanisms

2014-04-15 Thread Wang Weijun
Please review the code changes at http://cr.openjdk.java.net/~weijun/8039853/webrev.00/ If you find it confused, I have mistakenly pushed some code changes in http://hg.openjdk.java.net/jdk9/dev/jdk/rev/ba6e2fcdfa15 and the current code change is trying to fix/enhance it. Altogether, the ac