Re: RFR 8036709: Java 7 jarsigner displays warning about cert policy tree

2014-05-27 Thread Weijun Wang
On 5/28/2014 3:46, Sean Mullan wrote: Ok. The fix looks fine to me, though it looks like the code in the 2 methods is very similar - could it be refactored into a common method? Yes, it's now http://cr.openjdk.java.net/~weijun/8036709/webrev.02/ Thanks Max

Webrev request: JDK-8015081

2014-05-27 Thread Jamil Nimeh
Hello all, This bug was originally to resolve issues where Subject principal and credential Set fields containing null elements could cause NullPointerException to be thrown. It was decided to make the Subject throw NullPointerException when attempts to construct or modify Subjects will null

Re: RFR [8043507]: (smartcardio) Card.transmitControlCommand() does not work on Mac OS X

2014-05-27 Thread Valerie (Yu-Ching) Peng
Looks good. Thanks, Valerie On 05/27/14 04:59, Ivan Gerasimov wrote: Hello! SunPCSC provider uses SCardControl() function to send a request to the cardreader. However, on MacOSX pcsc-lite API has two similar functions exported: SCardControl and SCardControl132. The second function is actuall

Re: RFR: 8044059: Memory Leak in Elliptic Curve Private Key Generation

2014-05-27 Thread Vincent Ryan
Thanks Jeremy. I believe you have JDK 9 Author status so can sponsor your fix if you wish. On 27 May 2014, at 21:09, Jeremy Manson wrote: > Just like the title says - every time you generate a new private key, you > leak a little memory. Webrev here: > > http://cr.openjdk.java.net/~jmanson/80

Re: RFR 8036709: Java 7 jarsigner displays warning about cert policy tree

2014-05-27 Thread Sean Mullan
On 05/22/2014 07:42 PM, Wang Weijun wrote: On May 23, 2014, at 2:15, Sean Mullan wrote: Hi Max, Did you consider using a CertPathBuilder instead? This should essentially do the same thing (find a matching trust anchor, and build a validated path). I thought about it but anyway the certcha

RFR [8043720] (smartcardio) Native memory should be handled more accurately

2014-05-27 Thread Ivan Gerasimov
Hello! Here is a proposal to make some native memory manipulations in src/share/native/sun/security/smartcardio/pcsc.c more accurate. 1) Add another argument to pcsc_multi2jstring() which will hold the size of the character array to be parsed. In the function we make sure we do not access me

RFR [8043507]: (smartcardio) Card.transmitControlCommand() does not work on Mac OS X

2014-05-27 Thread Ivan Gerasimov
Hello! SunPCSC provider uses SCardControl() function to send a request to the cardreader. However, on MacOSX pcsc-lite API has two similar functions exported: SCardControl and SCardControl132. The second function is actually the one we need to use: The first function has different signature an

GSSCredential inside Subject?

2014-05-27 Thread Wang Weijun
Hi Valerie I am working on breaking JGSS into modules and is now looking at sun/security/jgss/GSSUtil.java. There is a method public static Vector searchSubject(final GSSNameSpi name, final Oid mech, final boolean initiate,