Re: Webrev request: JDK-8015081

Hello all, This is an update to the webrev for JDK-8015081 that takes into account review changes and adds a few more tests. http://cr.openjdk.java.net/~ascarpino/8015081/webrev.03 Thanks! --Jamil On 05/27/2014 05:53 PM, Jamil Nim

Re: Code review request, 8044771, PKIXValidator indent cleanup

On 6/5/2014 2:00 AM, Bradford Wetmore wrote: > > On 6/4/2014 2:38 AM, Xuelei Fan wrote: >> Webrev toolkit ignore space update so the webrev above looks strange. >> The major update is cleanup the indentation. For example, 4 leading >> space are removed at line 250 of PKIXValidator.java. > > Use

Re: Code review request, 8044771, PKIXValidator indent cleanup

On 6/4/2014 2:38 AM, Xuelei Fan wrote: Webrev toolkit ignore space update so the webrev above looks strange. The major update is cleanup the indentation. For example, 4 leading space are removed at line 250 of PKIXValidator.java. Use the -b option in webrev to force whitespace changes to app

Re: RFR: 8044740: Convert all JDK versions used in @since tag to 1.n[.n] in jdk repo

Thanks for all reviewing and feedbacks on core-libs-dev[1], I tried to respond to feedbacks with this email and send off to other mailing lists. I am wondering if jdk9-dev is the appropriate list for such a trivious but broad change, so that we can have one instead of many lists, and we still

Re: Code review request, 8044771, PKIXValidator indent cleanup

Looks fine. Please remember to add a noreg-cleanup to JBS. Thanks Max On Jun 4, 2014, at 17:38, Xuelei Fan wrote: > Hi, > > Please review this code conversion cleanup update: > >http://cr.openjdk.java.net/~xuelei/8044771/webrev.00/ > > Webrev toolkit ignore space update so the webrev abo

Code review request, 8044771, PKIXValidator indent cleanup

Hi, Please review this code conversion cleanup update: http://cr.openjdk.java.net/~xuelei/8044771/webrev.00/ Webrev toolkit ignore space update so the webrev above looks strange. The major update is cleanup the indentation. For example, 4 leading space are removed at line 250 of PKIXValida

Re: RFR 8044755: Add a test for algorithm constraints check in jarsigner

Ok. > Oh, my habit is to always keeping them so that if anything goes > wrong ... Ok. Xuelei On 6/4/2014 4:26 PM, Wang Weijun wrote: > Oh, I was just updating the webrev to > > http://cr.openjdk.java.net/~weijun/8044755/webrev.01/ > > As we've just discussed offline, the reason the 2nd jars

Re: RFR 8044755: Add a test for algorithm constraints check in jarsigner

On Jun 4, 2014, at 16:20, Xuelei Fan wrote: > FYI, I'd like to remove the temporary files (a.jar, ks, etc) after a > testing. Oh, my habit is to always keeping them so that if anything goes wrong there is a chance to look at what's happening. Also, jtreg takes care of removing or retaining th

Re: RFR 8044755: Add a test for algorithm constraints check in jarsigner

Oh, I was just updating the webrev to http://cr.openjdk.java.net/~weijun/8044755/webrev.01/ As we've just discussed offline, the reason the 2nd jarsigner call fails is a double weakness, not only the signer's key is 512 bit, but also signer's cert is signed by a 512 key (of CA). Therefore I

Re: RFR 8044755: Add a test for algorithm constraints check in jarsigner

Looks fine to me. FYI, I'd like to remove the temporary files (a.jar, ks, etc) after a testing. Xuelei On 6/4/2014 2:21 PM, Wang Weijun wrote: > Please review a new test at > > http://cr.openjdk.java.net/~weijun/8044755/webrev.00/ > > It makes sure the CertPath validation check in jarsigner