Re: ThreadLocalRandom clinit troubles

2014-07-11 Thread Martin Buchholz
Thanks to Peter for digging into the secure seed generator classes and coming up with a patch. Openjdk security folks, please review. I confess to getting lost whenever I try to orient myself in the twisty maze of seed generator implementation files. Anyways, it seems important to have prngs lik

RFR: 8049892: Replace uses of 'new Integer()' with appropriate alternative across core classes

2014-07-11 Thread Otávio Gonçalves de Santana
https://bugs.openjdk.java.net/browse/JDK-8049892 http://cr.openjdk.java.net/~prr/8049892/ -- Cheers!. Otávio Gonçalves de Santana blog: http://otaviosantana.blogspot.com.br/ twitter: http://twitter.com/otaviojava site: *http://about.me/otaviojava * 55 (11) 98

Re: RFR: 8049892: Replace uses of 'new Integer()' with appropriate alternative across core classes

2014-07-11 Thread Andrej Golovnin
Hi Otávio, changes to the classes in the package "jdk.internal.org.objectweb.asm" should be done directly in the ASM library. Please exclude following classes from the patch: src/share/classes/jdk/internal/org/objectweb/asm/ClassReader.java src/share/classes/jdk/internal/org/objectweb/asm/Opcodes

Re: RFR: [8049250]: (smartcardio) Need a flag to inverse the Card.disconnect(reset) argument

2014-07-11 Thread Valerie Peng
Looks fine. Thanks, Valerie On 7/11/2014 6:23 AM, Ivan Gerasimov wrote: And another request for integrating the fix into 7u. This one is needed quite urgently, so if you could review the fix until the end of the week, it would really be appreciated! The only difference from the 8u fix is the

Re: RFR: [8049250]: (smartcardio) Need a flag to inverse the Card.disconnect(reset) argument

2014-07-11 Thread Valerie Peng
Looks fine. Thanks, Valerie On 7/11/2014 4:09 AM, Ivan Gerasimov wrote: I updated the webrev - changed the option name to match one in ccc. http://cr.openjdk.java.net/~igerasim/8049250/1/webrev/ Would you please review/approve the fix, pending the ccc approval? Sincerely yours, Ivan On 06.07

Re: RFR: [8049250]: (smartcardio) Need a flag to inverse the Card.disconnect(reset) argument

2014-07-11 Thread Ivan Gerasimov
And another request for integrating the fix into 7u. This one is needed quite urgently, so if you could review the fix until the end of the week, it would really be appreciated! The only difference from the 8u fix is the default value of "true". http://cr.openjdk.java.net/~igerasim/8049250/2/w

Re: RFR: [8049250]: (smartcardio) Need a flag to inverse the Card.disconnect(reset) argument

2014-07-11 Thread Ivan Gerasimov
I updated the webrev - changed the option name to match one in ccc. http://cr.openjdk.java.net/~igerasim/8049250/1/webrev/ Would you please review/approve the fix, pending the ccc approval? Sincerely yours, Ivan On 06.07.2014 21:35, Ivan Gerasimov wrote: Hello! With the fix for JDK-7047033,