Re: RFR 8054366: Broken link in SecureRandom.html

2014-08-07 Thread Bradford Wetmore
On 8/7/2014 3:59 PM, Sean Mullan wrote: On 08/07/2014 05:03 PM, Jamil Nimeh wrote: Hello all, This is just a quick broken-link fix for SecureRandom's javadoc. http://cr.openjdk.java.net/~ascarpino/8054366/webrev.01 The fix for the broken link looks fine. I think you should double-check wit

Re: RFR 8054366: Broken link in SecureRandom.html

2014-08-07 Thread Sean Mullan
On 08/07/2014 05:03 PM, Jamil Nimeh wrote: Hello all, This is just a quick broken-link fix for SecureRandom's javadoc. http://cr.openjdk.java.net/~ascarpino/8054366/webrev.01 The fix for the broken link looks fine. I think you should double-check with Brad as to whether changing the RFC refe

Re: RFR 8054366: Broken link in SecureRandom.html

2014-08-07 Thread Xuelei Fan
Looks fine to me. Thanks, Xuelei On 8/8/2014 5:03 AM, Jamil Nimeh wrote: > Hello all, > > This is just a quick broken-link fix for SecureRandom's javadoc. > > http://cr.openjdk.java.net/~ascarpino/8054366/webrev.01 > > Thanks, > --Jamil

RFR 8054366: Broken link in SecureRandom.html

2014-08-07 Thread Jamil Nimeh
Hello all, This is just a quick broken-link fix for SecureRandom's javadoc. http://cr.openjdk.java.net/~ascarpino/8054366/webrev.01 Thanks, --Jamil

[7u-dev] Request for approval: 8046343: (smartcardio) CardTerminal.connect('direct') does not work on MacOSX

2014-08-07 Thread Ivan Gerasimov
Hello! May I ask for the approval to backport into 7u-dev repo? The fix is the same as in jdk9/8u modulo lambda, so I'm including the webrev here. Jdk7 webrev: http://cr.openjdk.java.net/~igerasim/8046343/3/webrev/ Bug: https://bugs.openjdk.java.net/browse/JDK-8046343 Jdk9 change: http://hg.o

Re: [8u40] Request for approval: 8046343: (smartcardio) CardTerminal.connect('direct') does not work on MacOSX

2014-08-07 Thread Ivan Gerasimov
On 07.08.2014 18:07, Seán Coffey wrote: Ivan, No need to convert the JDK 9 patch here. Lambda in JDK 8u! I'm approving the jdk9 changeset for import into jdk8u-dev on condition that it applies cleanly. If it doesn't get a peer code review. Thanks Seán! Yes, it was meant to remove lambda in

Re: [8u40] Request for approval: 8046343: (smartcardio) CardTerminal.connect('direct') does not work on MacOSX

2014-08-07 Thread Seán Coffey
Ivan, No need to convert the JDK 9 patch here. Lambda in JDK 8u! I'm approving the jdk9 changeset for import into jdk8u-dev on condition that it applies cleanly. If it doesn't get a peer code review. regards, Sean. On 07/08/2014 13:21, Ivan Gerasimov wrote: Hello! May I ask for the approval

Re: [9] RFR: 8054380: X.509 cert extension SubjectAltName should allow digits as first character of dNSName

2014-08-07 Thread Sean Mullan
On 08/07/2014 08:47 AM, Florian Weimer wrote: I wonder why using the HTTPS to access works with the current jdk9-dev code. The name "www.3com.com" is only present in the SAN. Is the SAN extension non-critical? If so, that could explain why. We allow X509Certificates to

Re: [9] RFR: 8054380: X.509 cert extension SubjectAltName should allow digits as first character of dNSName

2014-08-07 Thread Florian Weimer
On 08/06/2014 08:32 PM, Jason Uh wrote: Please review this fix, which allows the first character of a DNSName in a SubjectAltName to be either a letter or a digit. http://cr.openjdk.java.net/~juh/8054380/webrev.01/ The test case should also check "123.example" and "www.123.example". This cha

[8u40] Request for approval: 8046343: (smartcardio) CardTerminal.connect('direct') does not work on MacOSX

2014-08-07 Thread Ivan Gerasimov
Hello! May I ask for the approval to backport into 8u-dev repo? The fix is the same as in jdk9 modulo lambda, so I'm including the webrev here. Jdk8 webrev: http://cr.openjdk.java.net/~igerasim/8046343/2/webrev/ Bug: https://bugs.openjdk.java.net/browse/JDK-8046343 Jdk9 change: http://hg.open

Re: apple.security.KeychainStore does not load private key (when called from javaws)

2014-08-07 Thread Florian Bruckner (3kraft)
Hi Sean, I have submitted the signed OCA yesterday. I'll let you know once it has been approved. regards, Florian On 05.08.14 21:47, Sean Mullan wrote: On 08/04/2014 11:10 AM, Florian Bruckner (3kraft) wrote: Hey guys, any feedback/comments on this? This seems like a reasonable change to