Re: RFR 6562449: LoginContext does not all allow overloading of login method in LoginModule

2014-08-18 Thread Wang Weijun
912 return modClass.getMethod(methodName, parameters); It would be better to call LoginModule.class.getMethod(). Also, do you want to add a test case that includes a good login() method but the class not extending LoginModule? This would show our fallback still works. Thanks Max O

Re: RFR 6562449: LoginContext does not all allow overloading of login method in LoginModule

2014-08-18 Thread Jamil Nimeh
Ping! Any takers out there? Many thanks, --Jamil On 08/11/2014 02:56 PM, Jamil Nimeh wrote: Hello all, This webrev covers a fix to LoginContext so it no longer selects the wrong method when a LoginModule method (login, logout, commit, etc.) has been overloaded. Bug: https://bugs.openjdk.j

Re: com.sun.crypto.provider.GHASH performance fix

2014-08-18 Thread Anthony Scarpino
On 08/18/2014 05:32 AM, Florian Weimer wrote: This change addresses a severe performance regression, first introduced in JDK 8, triggered by the negotiation of a GCM cipher suite in the TLS implementation. This regression is a result of the poor performance of the implementation of the GHASH fun

TLS extensions API, ALPN and HTTP 2.0

2014-08-18 Thread Simone Bordet
Hi, I was suggested to restart the discussion about the topic on this list. I would like to reboot a discussion around an improved TLS extensions API in order to support ALPN (see http://tools.ietf.org/html/rfc7301), which is the mechanism required by HTTP 2.0 to negotiate the new version of the

Re: RFR 8054817: File ccache only recognizes Linux and Solaris defaults

2014-08-18 Thread Sean Mullan
Looks fine to me. Do you still need to import java.lang.reflect.* though? --Sean On 08/11/2014 10:14 AM, Wang Weijun wrote: Please review the fix at http://cr.openjdk.java.net/~weijun/8054817/webrev.00 since we have a new getuid() now for all Unix systems. It does return -1 on Windows, b

Re: AES GCM slow

2014-08-18 Thread Florian Weimer
On 01/27/2014 05:46 PM, Michael StJohns wrote: GCM uses a GF2 multiply as part of the integrity calculation. That operation is pretty expensive. My guess is that if the code was profiled, you'd find a lot of time being spent in com.sun.crypto.provider.GHASH. I ran into this and posted a fix:

Re: RFR 8048052: Permission tests for "setFactory"

2014-08-18 Thread Wang Weijun
We don't write "@bug JDK-8048052". Should be "@bug 8048052". --Max On Jul 28, 2014, at 17:04, FELIX YANG wrote: > Please review a new test to "setFactory" permission. It is to address that > "setFactory" permission is required or not as expected in a series of > classes/methods under java.net

Re: RFR 8048052: Permission tests for "setFactory"

2014-08-18 Thread Sean Mullan
On 07/28/2014 05:04 AM, FELIX YANG wrote: Please review a new test to "setFactory" permission. It is to address that "setFactory" permission is required or not as expected in a series of classes/methods under java.net. JDK Issue: https://bugs.openjdk.java.net/browse/JDK-8048052 Webrev: http://cr

com.sun.crypto.provider.GHASH performance fix

2014-08-18 Thread Florian Weimer
This change addresses a severe performance regression, first introduced in JDK 8, triggered by the negotiation of a GCM cipher suite in the TLS implementation. This regression is a result of the poor performance of the implementation of the GHASH function. I first tried to eliminate just the

Re: [JDK-9] RFR: 8050370: Need new regressions tests for messageDigest with DigestIOStream

2014-08-18 Thread Wang Weijun
Hi Kevin I tried to read the new test. TestMDChange and TestMDShare are OK, but I am confused on what testDigestOnOff is doing. Can you add some comments there? Thanks Max On Aug 18, 2014, at 14:35, zaiyao liu wrote: > Hi Brad, > > Can you help to review this new test for DigestIOStream? >