Code change looks fine, but you will need to translate the file path to new
module style.
There are also 2 useless imports:
import java.util.LinkedList;
import java.security.AccessController;
--Max
On Aug 22, 2014, at 9:12, Jamil Nimeh wrote:
> One more update, with Max's nits addressed:
>
One more update, with Max's nits addressed:
http://cr.openjdk.java.net/~weijun/6562449/webrev.03
--Jamil
On 08/20/2014 02:38 PM, Jamil Nimeh wrote:
Hello everyone,
This is an updated review that addresses comments from the original
webrev.
http://cr.openjdk.java.net/~ascarpino/6562449/webr
Looks good Vinnie. Thanks for handling this. One more comment from me..
I recently worked with a group who were reading the verbose security
messages when trying to debug an SSL connection issue. They weren't sure
if two-way SSL authentication was set up between the server and client.
Could we
Hi Sean,
Thank you for reviewing this. I have improved codes by your suggestions.
New webrev link:
http://cr.openjdk.java.net/~tyan/amandaj/8050281/webrev.02/
Thanks,
Amanda
On 8/19/14 10:13 AM, Sean Mullan wrote:
On 08/06/2014 06:25 PM, Amanda Jiang wrote:
Sorry, wrong webrev link, it should
Please review this trivial enhancement to JSSE to warn when TLS client
authentication cannot be completed
because of difficulty locating a suitable client certificate. (Keystore file
paths are already displayed by JSSE, when known)
This is useful to help troubleshoot configuration issues relate
Hi Vincent,
excellent - thanks for your support - what are the next steps for me to do?
regards,
Florian
On 21.08.14 11:28, Vincent Ryan wrote:
Hello Florian,
I can sponsor this changeset and attribute the fix to you.
On 21 Aug 2014, at 09:52, Florian Bruckner (3kraft)
wrote:
Hi Sean,
I also see a lot of .toString() and String.valueOf() calls.
$ cat string_concat_updated.patch | perl -ne 'print if /^\+
.*append.*(String\.valueOf|\.toString\(\))/' | wc
62 2104626
Wrapped lines not indented correctly in
src/java.xml.crypto/share/classes/com/sun/org/apache/xml/int
On Aug 21, 2014, at 21:18, Andrej Golovnin wrote:
>https://bugs.openjdk.java.net/browse/JDK-8038277
>
> This is not the right bug report. The subject of this bug report is "Improve
> the bootstrap performance of carets keystore".
Oh, my mistake, it should be https://bugs.openjdk.java.net/
>
>https://bugs.openjdk.java.net/browse/JDK-8038277
This is not the right bug report. The subject of this bug report is
"Improve the bootstrap performance of carets keystore".
>
>http://cr.openjdk.java.net/~weijun/8038277/client/webrev.00
TABs are still used for indentation. I looked
I filed a bug at
https://bugs.openjdk.java.net/browse/JDK-8038277
Webrev in 3 parts at
http://cr.openjdk.java.net/~weijun/8038277/client/webrev.00
http://cr.openjdk.java.net/~weijun/8038277/core/webrev.00/
http://cr.openjdk.java.net/~weijun/8038277/extra/webrev.00/
--Max
On Aug 21,
Hello Florian,
I can sponsor this changeset and attribute the fix to you.
On 21 Aug 2014, at 09:52, Florian Bruckner (3kraft)
wrote:
> Hi Sean,
>
> the OCA has been approved - what are the next steps?
>
> With best regards,
>
> Florian
>
> On 05.08.14 21:47, Sean Mullan wrote:
>>
>> This
Hi Sean,
the OCA has been approved - what are the next steps?
With best regards,
Florian
On 05.08.14 21:47, Sean Mullan wrote:
This seems like a reasonable change to me. In order to proceed with accepting your patch, you will
first need to sign an OCA. See step 0 of http://openjdk.java.net/
12 matches
Mail list logo
