Change looks good to me.
/Erik
On 2014-09-10 18:28, Valerie Peng wrote:
Could someone please review this build related change for moving
sunpkcs11-solaris.cfg file to the pkcs11 module?
Webrev: http://cr.openjdk.java.net/~valeriep/8039898/webrev.00/
Thanks,
Valerie
On 2014-09-10 18:28, Valerie Peng wrote:
Could someone please review this build related change for moving
sunpkcs11-solaris.cfg file to the pkcs11 module?
Webrev: http://cr.openjdk.java.net/~valeriep/8039898/webrev.00/
Looks good. However, I'll give the same feedback to you as I just
On 11/09/2014 10:38, Magnus Ihse Bursie wrote:
On 2014-09-10 18:28, Valerie Peng wrote:
Could someone please review this build related change for moving
sunpkcs11-solaris.cfg file to the pkcs11 module?
Webrev: http://cr.openjdk.java.net/~valeriep/8039898/webrev.00/
Looks good. However,
On 2014-09-11 11:51, Alan Bateman wrote:
On 11/09/2014 10:38, Magnus Ihse Bursie wrote:
The webrev shows the file as being moved outside the control of
mercurial. That is, if you do hg mv to move the file, the history
of the file will be kept intact. Otherwise it will look like a new
file in
Hello there, I am currently attempting to get to the bottom of some
interoperability issues regarding the handling of Kerberos AP_REQ
messages that contain a delegated credential.
Before I start raising bug reports I wanted to pass it through you guys
first in case there is a strong
Thanks all for the review and tips on webrev.
I have re-generated the webrev following all the tips...
Thanks again,
Valerie
On 9/11/2014 3:42 AM, Magnus Ihse Bursie wrote:
On 2014-09-11 11:51, Alan Bateman wrote:
On 11/09/2014 10:38, Magnus Ihse Bursie wrote:
The webrev shows the file as
Hi Jason,
I have removed those lines from copyright headers. Here is the
updated webrev.
http://cr.openjdk.java.net/~rhalade/8049039/webrev.04/
Thanks,
Raghu Nair
On 9/6/2014 1:58 AM, Jason Uh wrote:
Hi Raghu,
Formatting looks good, but one last thing about the copyright headers.
I
On line 83 of EncodedKeySpec, call algorithm.isEmpty() instead.
Looks good otherwise.
--Sean
On 09/10/2014 07:14 PM, Jason Uh wrote:
Please review this change, which adds a constructor taking an algorithm
name parameter to EncodedKeySpec and its subclasses. This allows the
algorithm name to be
