[9] request for review: 8059627: Enable PKCS11 tests on Mac

2014-10-02 Thread Vincent Ryan
Please review this enhancement to support running the PKCS11 testsuite on Mac. The NSS libraries for Mac OSX are included with the testsuite as they might not be present on the platform. (This is similar to the way NSS libraries for Windows are also included.) Bug: https://bugs.openjdk.java.net/b

[9] Request for review: 8041740: Test sun/security/tools/keytool/ListKeychainStore.sh fails on Mac

2014-10-02 Thread Vincent Ryan
Please review this fix to a test for KeychainStore keystores on Mac OSX. It adjusts the keychain search order to include the temporary keychain created by this test. Bug: https://bugs.openjdk.java.net/browse/JDK-8041740 Webber: http://cr.openjdk.java.net/~vinnie/8041740/webrev.00/ Thanks.

RFR: 8004488 wrong permissions checked in krb5

2014-10-02 Thread Seán Coffey
I'm looking to backport this fix to JDK 7u code line. The fix applies pretty much as is with the JDK 8 fix with the exception of not having to deal with a ServiceCreds tgt variable (Krb5Util.java) which was only introduced in JDK 8 for : 6355584: Introduce constrained Kerberos delegation bug :

Re: RFR (XS) : 8031191 Warning exception when XMLSignature logging is enabled

2014-10-02 Thread Sean Mullan
Also looks fine to me. --Sean On 10/02/2014 06:25 AM, Chris Hegarty wrote: On 2 Oct 2014, at 06:00, Seán Coffey wrote: Simple fix to the issue reported in the bug report. I've moved the logging calls past the 'sa.initVerify(pk);" call. bug : https://bugs.openjdk.java.net/browse/JDK-8031191

Re: RFR (XS) : 8031191 Warning exception when XMLSignature logging is enabled

2014-10-02 Thread Chris Hegarty
On 2 Oct 2014, at 06:00, Seán Coffey wrote: > Simple fix to the issue reported in the bug report. I've moved the logging > calls past the 'sa.initVerify(pk);" call. > > bug : https://bugs.openjdk.java.net/browse/JDK-8031191 > webrev : http://cr.openjdk.java.net/~coffeys/webrev.8031191/webrev/

RFR (XS) : 8031191 Warning exception when XMLSignature logging is enabled

2014-10-02 Thread Seán Coffey
Simple fix to the issue reported in the bug report. I've moved the logging calls past the 'sa.initVerify(pk);" call. bug : https://bugs.openjdk.java.net/browse/JDK-8031191 webrev : http://cr.openjdk.java.net/~coffeys/webrev.8031191/webrev/ regards, Sean.

request for review : 8052406: SSLv2Hello protocol may be filtered out unexpectedly

2014-10-02 Thread Seán Coffey
I should have prefixed my comments with point that this is a request for review given the changes. Subject updated. regards, Sean. On 01/10/2014 17:23, Seán Coffey wrote: Turned out that I do need to make a change to this backport. The testcase hadn't run initially on JPRT due to a new path in

Re: PING: [7u80] Request for review for CR 4963723: Implement SHA-224

2014-10-02 Thread Seán Coffey
Valerie Peng (original author) is probably best suited to reviewing this but I think she's out of the office the moment and back next week. Let's hope we can get an update/review then. regards, Sean. On 01/10/2014 16:11, Andrew Hughes wrote: - Original Message - - Original Messa