Re: Review request for CR 8044193 Need to add known answer tests for AES cipher

2015-01-13 Thread Valerie Peng
Updated changes look good. Thanks, Valerie On 1/12/2015 5:37 PM, zaiyao liu wrote: Thanks Valerie for review. Please check the update: http://cr.openjdk.java.net/~zailiu/8044193/webrev.04/ Kevin 在 2015/1/13 5:07, Valerie Peng 写道: Hi, Kevin, Somehow I missed your Dec email, sorry for the lat

Re: [9] RFR: 8059916: Change default criticality of policy mappings and policy constraints certificate extensions

2015-01-13 Thread Sean Mullan
Looks good. --Sean On 01/13/2015 01:48 PM, Jason Uh wrote: Thanks, Sean. Could you also look at one more change I've added? http://cr.openjdk.java.net/~juh/8059916/02/ Line 103 of PolicyMappingsExtension.java: -extensionId = PKIXExtensions.KeyUsage_Id; -critical = false; +

Re: [9] RFR: 8059916: Change default criticality of policy mappings and policy constraints certificate extensions

2015-01-13 Thread Jason Uh
Thanks, Sean. Could you also look at one more change I've added? http://cr.openjdk.java.net/~juh/8059916/02/ Line 103 of PolicyMappingsExtension.java: -extensionId = PKIXExtensions.KeyUsage_Id; -critical = false; +extensionId = PKIXExtensions.PolicyMappings_Id; +c

Re: [9] RFR: 8059916: Change default criticality of policy mappings and policy constraints certificate extensions

2015-01-13 Thread Sean Mullan
Looks good to me. --Sean On 01/12/2015 06:56 PM, Jason Uh wrote: Please review this change, which changes the default criticality of the policy mappings and policy constraints certificate extensions. This change makes both extensions critical by default, per RFC 5280. webrev: http://cr.openjdk

Re: [9] request for review 8059009: LDAPCertStore fails to retrieve CRL after LDAP server closes idle connection

2015-01-13 Thread Vincent Ryan
Your fix looks good. Thanks. On 1 Dec 2014, at 18:10, Artem Smotrakov wrote: > Please review this fix for 9. > > It corrects the following issues: > - InitialLdapContext and LDAPCertStore does not recover connection if it was > closed, for example, by server, or due to some network issue > -