Re: [9] request for review: 8049171: Additional tests for jarsigner's warnings

2015-01-25 Thread Artem Smotrakov
Hi Max, Here is an updated webrev, please take a look. http://cr.openjdk.java.net/~asmotrak/8049171/webrev.02/ Artem On 01/26/2015 05:03 AM, Weijun Wang wrote: On 1/23/2015 16:12, Artem Smotrakov wrote: If the MANIFEST and the signature files must be at the beginning, should it be consider

Re: [9] RFR: 8042967: Add variant of DSA Signature algorithms that do not ASN.1 encode the signature bytes

2015-01-25 Thread Michael StJohns
Sorry - I missed this the first time around I think this may not be the right approach... I'm concerned with trying to overload ECDSA and DSA which have always had relationships with very specific specifications and trying to make them also cover P1363. A better approach may be to create

Re: [9] request for review: 8049171: Additional tests for jarsigner's warnings

2015-01-25 Thread Weijun Wang
On 1/23/2015 16:12, Artem Smotrakov wrote: If the MANIFEST and the signature files must be at the beginning, should it be considered as a bug in jarsigner? Should it reject such files? I think so. Will file a bug. The "jar u" way is to copy each old entry into destination unless the entry