[JDK-9] RFR: 8050371: MessageDigest tests

2015-02-09 Thread zaiyao liu
Hi all, Please help to review those 2 new tests to be added for MessageDigest, New tests are added to address following: - Fixed length hash value is returned with different data inputs - Same hash value is returned with different update and digest methods JDK issue: https://bugs.openjdk.java

Re: RFR: 8065553: Failed Java web start via IPv6 (Java7u71 or later)

2015-02-09 Thread Rob McKenna
Thanks Xuelei, will do. -Rob On 10/02/15 01:59, Xuelei Fan wrote: Hi Rob, Sorry, I missed this review request. The change looks fine to me, except a minor coding style comment. 159InetAddress.getByName(ipAddress))) 160 { Would you mind join two lines together? We

Re: RFR: 8065553: Failed Java web start via IPv6 (Java7u71 or later)

2015-02-09 Thread Xuelei Fan
Hi Rob, Sorry, I missed this review request. The change looks fine to me, except a minor coding style comment. 159InetAddress.getByName(ipAddress))) 160 { Would you mind join two lines together? We normally don't use single line "{"". - 159InetAddress.getByName

Re: JDK 9 RFR of JDK-8069277: Doclint regression in java/security/KeyStore.java

2015-02-09 Thread Joseph D. Darcy
Hi Max, Yes; both should be "linkplain" -- I'll push with that fix. Thanks, -Joe On 2/9/2015 4:54 PM, Wang Weijun wrote: Should the "providers" link in the 2nd method also be "linkplain"? --Max On Feb 10, 2015, at 08:28, Joseph D. Darcy wrote: Hello, As the final purge of doclint warnin

Re: JDK 9 RFR of JDK-8069277: Doclint regression in java/security/KeyStore.java

2015-02-09 Thread Wang Weijun
Should the "providers" link in the 2nd method also be "linkplain"? --Max > On Feb 10, 2015, at 08:28, Joseph D. Darcy wrote: > > Hello, > > As the final purge of doclint warnings from the java.base module approaches, > please review the changes for > >JDK-8069277: Doclint regression in j

JDK 9 RFR of JDK-8069277: Doclint regression in java/security/KeyStore.java

2015-02-09 Thread Joseph D. Darcy
Hello, As the final purge of doclint warnings from the java.base module approaches, please review the changes for JDK-8069277: Doclint regression in java/security/KeyStore.java http://cr.openjdk.java.net/~darcy/8069277.0/ Patch below. Thanks, -Joe --- old/src/java.base/share/classe

Re: RFR 8069072: GHASH performance improvement

2015-02-09 Thread Sean Mullan
This updated webrev looks good to me. --Sean On 02/09/2015 02:15 PM, Florian Weimer wrote: Micro-benchmarks show a ten-fold performance increase, which is very noticeable with TLS connections using the AES-GCM cipher suites, as discussed here:

RFR 8069072: GHASH performance improvement

2015-02-09 Thread Florian Weimer
Micro-benchmarks show a ten-fold performance increase, which is very noticeable with TLS connections using the AES-GCM cipher suites, as discussed here: and here: