Re: Please review CR8048360 Test signed jar files

2015-02-25 Thread Weijun Wang
Looks fine. Thanks Max On 2/26/2015 4:41, Amanda Jiang wrote: Hi All, Could you please review following changeset for 1 new test, which check various combinations of permissions to execute the code from a signed jar file. Bug: https://bugs.openjdk.java.net/browse/JDK-8048360 webrev: http://cr

Re: RFR 8073853: KeyToolTest.java has too many too long lines

2015-02-25 Thread Sean Mullan
Looks fine. --Sean On 02/25/2015 10:41 AM, Weijun Wang wrote: Hi Sean Please review the change at http://cr.openjdk.java.net/~weijun/8073853/webrev.00 After the change, the output of the following command does not change at all. javac -g:vars,source KeyToolTest.java Thanks Max

Please review CR 8050409: Test for JAAS getPrivateCredentials

2015-02-25 Thread Amanda Jiang
Hi All, Could you please review following changeset, which includes one new test to test permission checks with Subject.getPrivateCredentials. Bug: https://bugs.openjdk.java.net/browse/JDK-8050409 Webrev:http://cr.openjdk.java.net/~tyan/amandaj/8050409/webrev.02/ Thanks, Amanda

Please review CR8048360 Test signed jar files

2015-02-25 Thread Amanda Jiang
Hi All, Could you please review following changeset for 1 new test, which check various combinations of permissions to execute the code from a signed jar file. Bug: https://bugs.openjdk.java.net/browse/JDK-8048360 webrev: http://cr.openjdk.java.net/~tyan/amandaj/8048360/webrev.01/

RFR 8073853: KeyToolTest.java has too many too long lines

2015-02-25 Thread Weijun Wang
Hi Sean Please review the change at http://cr.openjdk.java.net/~weijun/8073853/webrev.00 After the change, the output of the following command does not change at all. javac -g:vars,source KeyToolTest.java Thanks Max