Re: JDK 9 RFR of JDK-8077915: Fix doclint issues in javax.smartcardio

2015-04-15 Thread Yonathan
--- old/src/java.smartcardio/share/classes/javax/smartcardio/Card.java 2015-04-15 17:33:02.248101501 -0700 +++ new/src/java.smartcardio/share/classes/javax/smartcardio/Card.java 2015-04-15 17:33:02.072101497 -0700 @@ -82,6 +83,7 @@ * opened by issuing a MANAGE CHANNEL command that should use

JDK 9 RFR of JDK-8077915: Fix doclint issues in javax.smartcardio

2015-04-15 Thread joe darcy
Hello, The javax.smartcardio subcomponet in JBS is under the security-libs component so I suppose this is the best place to send a code review request. In any case, some missing doclint in javax.smartcardio is preventing doclint checking for that package being enabled in the build; please re

Re: [8u] RFR: 8076221: Disable RC4 cipher suites

2015-04-15 Thread Seán Coffey
Looks good. Approved. Regards, Sean. On 15/04/15 09:17, Artem Smotrakov wrote: cc'ing [email protected] Would you please approve this backport to 8u-dev? The difference is: - JDK 9 has a single java.security file, but JDK 8u has java.security file for each generic platform, so each

Re: [8u] RFR: 8076221: Disable RC4 cipher suites

2015-04-15 Thread Artem Smotrakov
cc'ing [email protected] Would you please approve this backport to 8u-dev? The difference is: - JDK 9 has a single java.security file, but JDK 8u has java.security file for each generic platform, so each file needs to be updated. - Test names are different, but the changes are the same

Re: [8u] RFR: 8076221: Disable RC4 cipher suites

2015-04-15 Thread Xuelei Fan
Looks fine to me. Xuelei On 4/15/2015 3:06 PM, Artem Smotrakov wrote: > Hello, > > RFC 7465 [1] has been published to prohibit RC4. > > Please review this fix which disables RC4 cipher suites in JDK 8u by > adding "RC4" to "jdk.tls.disabledAlgorithms" security property. > > Webrev: http://cr.o

[8u] RFR: 8076221: Disable RC4 cipher suites

2015-04-15 Thread Artem Smotrakov
Hello, RFC 7465 [1] has been published to prohibit RC4. Please review this fix which disables RC4 cipher suites in JDK 8u by adding "RC4" to "jdk.tls.disabledAlgorithms" security property. Webrev: http://cr.openjdk.java.net/~asmotrak/8076221/webrev.8u.00/ Bug: https://bugs.openjdk.java.net/bro