Re: RFR [9] 8078528: clean out tidy warnings from security.auth

2015-04-27 Thread alexander stepanov
Sorry, just a reminder... Regards, Alexander On 23.04.2015 19:22, alexander stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8078528/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8078528 Just some HTML markup cleanup for docs. T

Re: [9] RFR 8038084: CertStore needs a way to add new CertStore types

2015-04-27 Thread Sean Mullan
Hi Valerie, Looks good, just a couple of comments: - URICertStoreParameters and JdkLdap.java: please remove the @author tags, this tag is generally discouraged as the information can be obtained from the source code history. * URICertStoreParameters Couple of re-wording suggestions: First

Re: [9] RFR: 8075007: Additional tests for krb5-related cipher suites with unbound server

2015-04-27 Thread Weijun Wang
Looks fine. Thanks Max On 4/23/2015 6:31 PM, Artem Smotrakov wrote: Agree. Please see an updated webrev: http://cr.openjdk.java.net/~asmotrak/8075007/webrev.02/ Artem On 04/23/2015 11:18 AM, Weijun Wang wrote: One question: As for the 3 boolean flags you added to KDC.java (BTW, maybe "con