Re: JDK 9 RFR of JDK-8078334: Mark regression tests using randomness

2015-04-28 Thread Alan Bateman
On 29/04/2015 00:53, Joseph D. Darcy wrote: Hello, I'd like to get this changeset, or something close to it, pushed soon so we can start taking advantage of better failure triaging. Any further concerns? I should have been clearer, I don't have any issues with the proposed patch. I was mos

Re: RFR [9] 8078528: clean out tidy warnings from security.auth

2015-04-28 Thread Xuelei Fan
I had a quick read of the changes. All about doc cleanup, no behavior changes. I did not check every line of the update. It's OK to me if the update can pass a javadoc check. Thanks, Xuelei On 4/24/2015 12:22 AM, alexander stepanov wrote: > Hello, > > Could you please review the following fix

Re: Kerberos Bug Introduced in d777e2918a77?

2015-04-28 Thread Weijun Wang
On 4/28/2015 10:57 PM, Daniel Jones wrote: Hi (is it Max or Weijun? I don't want to be rude!) Either is OK. I've read through the code changes and static analysis with my eyes suggests the change looks good. The client is not in the habit of building OpenJDK regularly, but there's no reaso

Re: JDK 9 RFR of JDK-8078880: Mark a few more intermittently failing security-libs tests

2015-04-28 Thread Xuelei Fan
Looks fine to me. Thanks, Xuelei On 4/29/2015 8:44 AM, joe darcy wrote: > Hello, > > After additional testing, a few more security libs test have been > observed to intermittently fail. Please review the patch below to address > > JDK-8078880: Mark a few more intermittently failuring securi

JDK 9 RFR of JDK-8078880: Mark a few more intermittently failing security-libs tests

2015-04-28 Thread joe darcy
Hello, After additional testing, a few more security libs test have been observed to intermittently fail. Please review the patch below to address JDK-8078880: Mark a few more intermittently failuring security-libs tests Thanks, -Joe diff -r b9f8eb8938f4 test/sun/security/mscapi/SignU

Re: JDK 9 RFR of JDK-8078334: Mark regression tests using randomness

2015-04-28 Thread Joseph D. Darcy
Hello, I'd like to get this changeset, or something close to it, pushed soon so we can start taking advantage of better failure triaging. Any further concerns? Thanks, -Joe On 4/24/2015 11:04 AM, joe darcy wrote: On 4/23/2015 10:58 PM, Alan Bateman wrote: On 24/04/2015 02:54, Joseph D. Da

Re: [9] RFR 8038084: CertStore needs a way to add new CertStore types

2015-04-28 Thread Valerie Peng
Sean, Thanks for the review! Webrev has been updated at: http://cr.openjdk.java.net/~valeriep/8038084/webrev.01/ Can you please review the CCC as well? It's http://ccc.us.oracle.com/8038084 Thanks again, Valerie On 4/27/2015 7:11 AM, Sean Mullan wrote: Hi Valerie, Looks good, just a couple o

Re: Kerberos Bug Introduced in d777e2918a77?

2015-04-28 Thread Daniel Jones
Hi (is it Max or Weijun? I don't want to be rude!) I've read through the code changes and static analysis with my eyes suggests the change looks good. The client is not in the habit of building OpenJDK regularly, but there's no reason we can't give it a go. I had a look on http://hg.openjdk.java.

Re: Kerberos Bug Introduced in d777e2918a77?

2015-04-28 Thread Daniel Jones
Hi Weijun, Thanks for your help. Sorry it's taken me a while to reply, I was give other priorities over looking into this issue. Your suggested workaround does indeed work. I've switched elements of the byte array around with a debugger connected to the app, and that solves the problem. Thankfull

Re: Kerberos Bug Introduced in d777e2918a77?

2015-04-28 Thread Weijun Wang
On 4/28/2015 6:14 PM, Daniel Jones wrote: I noticed in the bug report Internet Explorer is mentioned. We see the same behaviour with IE, Firefox and Chrome. Thanks. I've mentioned that in the comment. BTW, are you able to build jdk yourself? If so, can you try out the fix? http://cr.openj