TLS Handshake Message Proposal (Was: Re: JEP 244: TLS Application-Layer Protocol Negotiation Extension)

2015-05-21 Thread Bradford Wetmore
Hi Thomas, After reviewing a lot of the back mail and the desires expressed, I have two orthogonal proposals to make. The first (next email) is an ALPN-specific API using a simple callback selector which I think addresses most of the protocol selection concerns. The second (below) is a mor

TLS ALPN Proposal

2015-05-21 Thread Bradford Wetmore
This is a fork of the previous thread: Subject: TLS Handshake Message Proposal (Was: Re: JEP 244: TLS Application-Layer Protocol Negotiation Extension) I broke this thread off to keep this proposal discussion together, but if you're interested in the history, pl

Re: RFR 7191662: JCE providers should be located via ServiceLoader,

2015-05-21 Thread Mandy Chung
I’m including build-dev and we need to ask for Erik and Magnus advice what’s the best way to work around this. Erik, Magnus, Security providers now become service providers. They are provided from 11 different modules, 3 of them are os-specific. The current image builder doesn’t merge dupl

Re: RFR 7191662: JCE providers should be located via ServiceLoader,

2015-05-21 Thread Valerie Peng
But you are correct that the content which uses jdk.crypto.ec seems inconsistent to the file name. I will fix those and re-test. Thanks, Valerie On 5/21/2015 3:03 PM, Valerie Peng wrote: Mandy, Please find comments in line. On 5/20/2015 10:39 PM, Mandy Chung wrote: A quick comment on the

Re: RFR 7191662: JCE providers should be located via ServiceLoader,

2015-05-21 Thread Valerie Peng
Mandy, Please find comments in line. On 5/20/2015 10:39 PM, Mandy Chung wrote: A quick comment on the META-INF/services config files and the makefile. Merging the service config files is temporary until the module system is moving further along. src/jdk.crypto.ucrypto/solaris/classes/META-

Re: [8u] request for review: 8062552 Support keystore type detection for JKS and PKCS12 keystores

2015-05-21 Thread Thomas Lußnig
Hi, most of it look ok for me, but in "http://cr.openjdk.java.net/~vinnie/8062552/webrev.01/src/share/classes/sun/security/util/KeyStoreDelegator.java.patch"; i found in the method engineLoad the exception handling an bit ugly. +} catch (Exception e) { + +// in

Re: [9] RFR 8079693: Add support for ECDSA P-384 and P-521 curves to XML Signature

2015-05-21 Thread Sean Mullan
Minor typo on line 438 of DOMKeyValue: s/the one/one/ Otherwise, looks good. --Sean On 05/19/2015 07:17 PM, Jason Uh wrote: Please review this change, which adds support for two curves to XML Signature. webrev: http://cr.openjdk.java.net/~juh/8079693/00/ bug: https://bugs.openjdk.java.net/bro

[8u] request for review: 8062552 Support keystore type detection for JKS and PKCS12 keystores

2015-05-21 Thread Vincent Ryan
Please review this enhancement to JDK 8u that addresses a compatibility risk for certain applications that access keystores across JDK 8 and JDK 9 releases. The issue arises because the default keystore type is now PKCS12 in JDK 9 but is JKS in earlier releases. The problem can occur when a keyst

Re: [JEP-219/JDK-8043758] Code Review Request: Datagram Transport Layer Security (DTLS)

2015-05-21 Thread Xuelei Fan
On 5/21/2015 7:31 PM, Konstantin Shefov wrote: > Hi Xuelei, > > You have the following tests: "DTLSOverDatagram.java", "Reordered.java", > "Retransmission.java". Their code is pretty much the same despite some > differences. > I think it would be better to create a base test class with all common

Re: [JEP-219/JDK-8043758] Code Review Request: Datagram Transport Layer Security (DTLS)

2015-05-21 Thread Konstantin Shefov
Hi Xuelei, You have the following tests: "DTLSOverDatagram.java", "Reordered.java", "Retransmission.java". Their code is pretty much the same despite some differences. I think it would be better to create a base test class with all common code and then inherit tests from that class to avoid co

Re: [JEP-219/JDK-8043758] Code Review Request: Datagram Transport Layer Security (DTLS)

2015-05-21 Thread Xuelei Fan
On 5/21/2015 6:07 PM, Weijun Wang wrote: > NEED_UNWRAP_AGAIN: > > So you are asking the user to call unwrap() on nothing? Or no matter > what the argument is you just don't touch it? As previous behaviors, the argument may be not touched. For this case, the input would not be touched. > I'd rath

Re: [JEP-219/JDK-8043758] Code Review Request: Datagram Transport Layer Security (DTLS)

2015-05-21 Thread Weijun Wang
NEED_UNWRAP_AGAIN: So you are asking the user to call unwrap() on nothing? Or no matter what the argument is you just don't touch it? I'd rather see a new status NEED_PROCEED and a new method proceed() that has no argument at all. Tests: I see you send/receive data with DatagramSocket. Not s

Re: [8u-dev] Request for review AND approval to backport: 8077102:

2015-05-21 Thread Seán Coffey
Approved. Regards, Sean. On 21/05/2015 07:46, Weijun Wang wrote: Code change is fine. Thanks Max On 5/21/2015 12:58 AM, Ivan Gerasimov wrote: Hi! The backport required some manual editing, thus I'm asking for a review too. Would you please review and approve backporting this fix? BUGURL: h

Fwd: 8078439: 8048194: possible bug in commit for these two fixes

2015-05-21 Thread Seán Coffey
FYI, concerns from Darwin on the 8078439: 8048194 fixes. regards, Sean. Forwarded Message Subject:8078439: 8048194: possible bug in commit for these two fixes Date: Wed, 20 May 2015 16:28:29 -0700 From: Darwin Felix To: jdk8u-...@openjdk.java.net CC: darwi