On 6/15/2015 5:58 PM, Florian Weimer wrote:
> On 06/03/2015 03:56 AM, Xuelei Fan wrote:
>
>> I can sponsor you for the specification update approval and changeset
>> integration if needed.
>
> I'd really appreciate that.
>
>> I still have a few comments about this fix:
>>
>> 1. TLS_FALLBACK_SCSV
Thanks for taking this on.
It looks good, except for one thing. The intrinsic does not need to be an
instance method, and doing so creates an undesirable coupling between the JVM
and JDK. Specifically, the JDK should not need to know about subkeyH and state
fields. The Java code should pass
It seems that the jimage refresh change may still take some time, so we
will end up removing the makefile related changes and then deferring the
ServiceLoader related changes to Jake workspace.
Here is the latest webrev (Security source/test changes only, no more
makefile changes)
http://cr
Hi other reviewers,
I'm hoping someone else can review this.
Tony
On 06/12/2015 03:16 PM, Vladimir Kozlov wrote:
This implementation looks good to me. You need second review since
changes are big.
Thanks,
Vladimir
On 6/11/15 11:01 AM, Anthony Scarpino wrote:
Now that JEP 246 is targeted, I
Sean,
Given how trivial this is, I initially covered it in the fix for 7191662.
However, fix for 7191662 took longer than anticipated to go in and now
SQE has filed a bug for this.
Thus, I separated this out into a separate webrev. Can u please take a
look?
http://cr.openjdk.java.net/~valeri
On 06/15/2015 09:58 AM, Andrew Haley wrote:
On 06/15/2015 05:38 PM, Anthony Scarpino wrote:
On 06/12/2015 04:06 AM, Andrew Haley wrote:
http://cr.openjdk.java.net/~aph/8046943-hs-1/
http://cr.openjdk.java.net/~aph/8046943-jdk-1/
Please don't use the JEP 246 in the comments when you push. Ther
On 06/15/2015 05:38 PM, Anthony Scarpino wrote:
> On 06/12/2015 04:06 AM, Andrew Haley wrote:
>> http://cr.openjdk.java.net/~aph/8046943-hs-1/
>> http://cr.openjdk.java.net/~aph/8046943-jdk-1/
>
> Please don't use the JEP 246 in the comments when you push. There are a
> number of changesets relat
[Resent: I dropped the security list by mistake]
On 06/12/2015 04:06 AM, Andrew Haley wrote:
http://cr.openjdk.java.net/~aph/8046943-hs-1/
http://cr.openjdk.java.net/~aph/8046943-jdk-1/
Please don't use the JEP 246 in the comments when you push. There are a
number of changesets related to 24
On 06/03/2015 03:56 AM, Xuelei Fan wrote:
> I can sponsor you for the specification update approval and changeset
> integration if needed.
I'd really appreciate that.
> I still have a few comments about this fix:
>
> 1. TLS_FALLBACK_SCSV may still be miss-used as it is defined as a
> default en
