Re: RFR 8023546: sun/security/mscapi/ShortRSAKey1024.sh fails intermittently

2015-06-22 Thread Weijun Wang
Hi Michael Webrev updated at http://cr.openjdk.java.net/~weijun/8023546/webrev.01 I added a check about the extra sign byte, I even added a null check in KeyStore.java, although if the fix is done right they should never happen. The return value of the convertToLittleEndian() function is n

Re: RFR: JEP 249 (OCSP Stapling for TLS)

2015-06-22 Thread Xuelei Fan
src/java.base/share/classes/sun/security/ssl/HandshakeStateManager.java === Thanks for the correction of typos, etc. line 777-797. Mayber, we can use the "default" block at line 857, and may not need the block from line 777 to 797

Re: RFR: JEP 249 (OCSP Stapling for TLS)

2015-06-22 Thread Jamil Nimeh
Just one follow up from a previous set of comments: On 06/21/2015 12:12 PM, Thomas Lußnig wrote: On 21.06.2015 17:56, Jamil Nimeh wrote: The X509TrustManager, if configured to do revocation checking at all, should handle the checks so the client doesn't have to. Can you tell me a little more a