Re: [9] RFR: 8048596: Tests for AEAD ciphers

2015-07-22 Thread Valerie Peng
Yeah, many ways to generate bytes. It's generally ok to just re-use the same input for various test scenarios in the same test class. As far as I am concerned, the benefit of get data in one line doesn't quite justify the extra dependency. The updated webrev looks fine. Valerie On 7/20/2015

RFR [9] 8132130: some docs cleanup

2015-07-22 Thread alexander stepanov
Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8132130/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8132130 Just some docs cleanup (fix invalid tags, parameter names, remove obsolete tags) Thanks, Alexander

Re: [9] RFR: 8130031: Remove the intermittent keyword for this test

2015-07-22 Thread Xuelei Fan
ok. Xuelei On 7/22/2015 2:49 PM, Rajan Halade wrote: > Please help me with your review for this one line fix to remove > intermittent keyword. The test is pretty stable now. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8130031 > Webrev: http://cr.openjdk.java.net/~rhalade/8130031/webrev.00/