Re: RFR: JDK-8077055 : Allow other named SecurityPermissions, RuntimePermissions, and AuthPermissions to be used

2015-08-10 Thread Weijun Wang
Everything is fine. One thing in AuthPermission.java: + * {@link javax.security.auth.login.LoginContext}, and + * {@link javax.security.auth.login.Configuration} objects. I remember you can add an additional label in {@link}, otherwise, the text is too long. Thanks Max On 08/07/2015 04:06 AM

Re: 7u Code review request for 7033170, 7092821, 7092825

2015-08-10 Thread Valerie Peng
Well, I used to have a workspace containing a prototype fix, but I didn't get to run the benchmark against the prototype. Then, I went to work on other bug fixes and enhancement and this has been put on the back burners. Valerie On 8/7/2015 6:16 AM, Sean Mullan wrote: Hi David, On 08/07/201

Re: RFR 8044199: tests for RSA keys and key specifications

2015-08-10 Thread Valerie Peng
Tristan, - Given that the tests are against SunRsaSign provider, I think sun/security/rsa subdirectory is a better choice than java/security/rsa. - Put @test and @bug on separate lines - Elaborate more on what is tested and what is the expected result in the bug record. The current content isn

Re: [9] RFR: 8048624: Tests for SealedObject

2015-08-10 Thread Rajan Halade
Hi Valerie, I have updated the webrev after your comment and our discussion to only retain TestSealedObjectNull test. http://cr.openjdk.java.net/~rhalade/8048624/webrev.01/ Thanks, Rajan On 7/23/15 2:20 PM, Valerie Peng wrote: - I think it's more universal to call getParameters() instead o

[9] review request for JDK-8050460: JAAS login/logout tests with LoginContext

2015-08-10 Thread Svetlana Nikandrova
Hello, Please review tests for login/logout with LoginContex. Webrev: http://cr.openjdk.java.net/~asmotrak/sweta/8050460/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8050460 Thanks, Svetlana

Re: [9] RFR 8130665 "java/lang/SecurityManager/CheckSecurityProvider.java failing in jake on OS X"

2015-08-10 Thread Erik Joelsson
Hello Valerie, To reduce duplication, I think something like this would be preferable. Remove the windows and macosx checks and just always run this line: POLICY_SRC_LIST += \ $(wildcard $(JDK_TOPDIR)/src/java.base/$(OPENJDK_TARGET_OS)/conf/security/java.policy) That way, I platform spe