> On Aug 14, 2015, at 7:18 PM, Weijun Wang wrote:
>
>
>
> On 8/15/2015 5:37 AM, Mandy Chung wrote:
>> Looks good in general.
>>
>> Have you considered using “Algorithm” instead of “Alg” the abbreviation in
>> the method names digesting, sigAlg etc
>>
>
> I reuse the jarsigner option names
On 8/15/2015 5:37 AM, Mandy Chung wrote:
Looks good in general.
Have you considered using “Algorithm” instead of “Alg” the abbreviation in the
method names digesting, sigAlg etc
I reuse the jarsigner option names (-sigalg, -digestalg, -tsa), hoping
people are already familiar with them.
Looks good.
Mandy
> On Aug 14, 2015, at 4:30 PM, Valerie Peng wrote:
>
>
> Updated the webrev in place to use "osxsecurity" given peer feedbacks.
> Thanks,
> Valerie
>
> On 8/13/2015 7:31 PM, Valerie Peng wrote:
>>
>> Can someone please help reviewing this change?
>> This is to move Apple pro
Updated the webrev in place to use "osxsecurity" given peer feedbacks.
Thanks,
Valerie
On 8/13/2015 7:31 PM, Valerie Peng wrote:
Can someone please help reviewing this change?
This is to move Apple provider from jdk.deploy.osx module to java.base
module.
The native library for Apple provider
Looks good in general.
Have you considered using “Algorithm” instead of “Alg” the abbreviation in the
method names digesting, sigAlg etc
The Builder::build method:
After a {@code JarSigner} object is built, calling any setter method on this
{@code Builder} will have no effect on it.
Wil
This looks good to me.
--Sean
On 08/08/2015 09:56 AM, Weijun Wang wrote:
Hi All
JDK 9 is more restricted on calling sun.* public methods but we know
there are users calling sun.security.tools.jarsigner.Main to sign jar
files. A new API is proposed for this very purpose in OpenJDK. Please
note
> On Aug 13, 2015, at 7:31 PM, Valerie Peng wrote:
>
>
> Can someone please help reviewing this change?
> This is to move Apple provider from jdk.deploy.osx module to java.base module.
> The native library for Apple provider is separated out from the "osx" one
> generated in jdk.deploy.osx mod
Couple of minor comments on ProviderConfig.java
183: you can use the diamond operator for anonymous classes now
(PrivilegedAction<>). You could also use a lambda expression here but
I'll leave that up to you.
193: the braces around "if (debug != null)" are not indented properly
Looks fine ot
Build changes look good.
/Erik
On 2015-08-14 04:31, Valerie Peng wrote:
Can someone please help reviewing this change?
This is to move Apple provider from jdk.deploy.osx module to java.base
module.
The native library for Apple provider is separated out from the "osx"
one generated in jdk.dep
