Re: RFR 8048357: PKCS basic tests

Hello Amanda, out of curiosity I was looking at the tests, and have a few comments: PKCS7VerifyTest.java 63byte[] base64Bytes = new byte[pkcs7In.available()]; 64 if (pkcs7In.read(base64Bytes) < base64Bytes.length) { There are two pet peeves of mine. available() to get the

Re: [9] RFR: 8048601: Tests for JCE crypto ciphers

Rajan, Here are some comments for the other half of the webrev: TestCipherTextLength.java 1) line 82 and 85, why TEXT_LEN is needed? I don't find any usage of it inside runAll(..) method? 2) the names here are a bit too similar, e.g. PBEWrapper, PBECipherWrapper, AESPBEWrapper. The individual s

RFR 8048357: PKCS basic tests

Hi All, Please be free to review new tests for conformance testing of PKCS. bug: https://bugs.openjdk.java.net/browse/JDK-8048357 webrev: http://cr.openjdk.java.net/~amjiang/8048357/webrev.01/ Thanks, Amanda

Re: RFR 8075020: Additional interop tests for Java as HTTPS client

Please ignore the request. Thanks, Amanda On 8/20/15, 2:47 PM, Amanda Jiang wrote: Hi All, Please help to review following changeset which add some interoperability testing for Https Client Bug: https://bugs.openjdk.java.net/browse/JDK-8075020 webrev: http://cr.openjdk.java.net/~amjiang/807

RFR 8075020: Additional interop tests for Java as HTTPS client

Hi All, Please help to review following changeset which add some interoperability testing for Https Client Bug: https://bugs.openjdk.java.net/browse/JDK-8075020 webrev: http://cr.openjdk.java.net/~amjiang/8075020/webrev.01/ Thanks, Amanda

RE : RFR 8044199: tests for RSA keys and key specifications

Thanks Valerie Please review the fixed version. http://cr.openjdk.java.net/~tyan/8044199/webrev.02/ Tristan Tristan, - Given that the tests are against SunRsaSign provider, I think sun/security/rsa subdirectory is a better choice than java/security/rsa. - Put @test and @bug on separate line