RFR JDK-8134364: Add defensive copies to get/set methods for OCSPNonceExtension

2015-08-24 Thread Jamil Nimeh
Hi all, This is a quick fix to the OCSPNonceExtension class to add a couple defensive copies to public get/set methods. JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8134364 Webrev: http://cr.openjdk.java.net/~jnimeh/reviews/8134364/webrev.00 Thanks, --Jamil

Re: RFR [9] 8133802: replace some tags (obsolete in html5) in security-libs docs

2015-08-24 Thread Sean Mullan
On line 105 of RC5ParameterSpec, can you move the closing brace at the start of the line to the end of the previous line? Otherwise, everything else looks fine. --Sean On 08/24/2015 05:46 AM, Alexander Stepanov wrote: Sorry, just a reminder. Thanks, Alexander On 8/18/2015 1:56 PM, Alexander

Re: RFR 8056174: New APIs for jar signing

2015-08-24 Thread Weijun Wang
Typo, short method names. (Strange, I was typing in Linux and no auto-correct is on). --Max On 08/24/2015 09:56 PM, Weijun Wang wrote: I am still using should method names

Re: [9] review request for 8132786: java/security/cert/CertPathValidator/OCSP/AIACheck.java fails intermittently

2015-08-24 Thread Sean Mullan
Looks fine to me. --Sean On 08/19/2015 12:59 PM, Vincent Ryan wrote: Please review this fix for an intermittently failing test. It now expects a SocketException or a SocketTimeoutException. Thanks. Bug: https://bugs.openjdk.java.net/browse/JDK-8132786 Webrev: http://cr.openjdk.java.net/~vinni

RFR 8056174: New APIs for jar signing

2015-08-24 Thread Weijun Wang
Hi All Please review the code change at http://cr.openjdk.java.net/~weijun/8056174/webrev.02/ A new JarSigner public API is introduced to OpenJDK. The code change chooses a two-layer implementation style, with public JarSigner/Builder in jdk.security and private JarSignerX/BuilderX in sun.s

RFR : 8133535: Better exception messaging in Ucrypto code

2015-08-24 Thread Seán Coffey
Hoping to improve some of the exception messaging that is thrown from Ucrypto code. I'm hoping to tackle other components in the security libraries on a case by case basis. Aim is to improve exception messages and capture detail for end user where possible. bug report : https://bugs.openjdk.ja

RFR [9] 8133802: replace some tags (obsolete in html5) in security-libs docs

2015-08-24 Thread Alexander Stepanov
Sorry, just a reminder. Thanks, Alexander On 8/18/2015 1:56 PM, Alexander Stepanov wrote: Hello, Could you please review the following fix: http://cr.openjdk.java.net/~avstepan/8133802/webrev.00 for https://bugs.openjdk.java.net/browse/JDK-8133802 Just another portion of deprecated tags repl