Re: [9] RFR: 8130875 Out of memory when using TLS_RSA_WITH_AES_128_GCM_SHA256

2015-09-02 Thread Anthony Scarpino
> On Sep 2, 2015, at 3:45 PM, Valerie Peng wrote: > > > Can someone help review this java workaround for Solaris memory leak bug in > Ucrypto library? > Essentially, the memory leak occurs when a null output buffer is specified > when doing encryption/decryption. > So, the workaround in Oracl

[9] RFR: 8130875 Out of memory when using TLS_RSA_WITH_AES_128_GCM_SHA256

2015-09-02 Thread Valerie Peng
Can someone help review this java workaround for Solaris memory leak bug in Ucrypto library? Essentially, the memory leak occurs when a null output buffer is specified when doing encryption/decryption. So, the workaround in OracleUcrypto provider is to use non-null output buffers. Webrev: ht

Re: RFR 8129789: implies() of ServicePermission and DelegationPermission underspecified

2015-09-02 Thread Sean Mullan
Looks good. --Sean On 09/01/2015 10:05 PM, Weijun Wang wrote: Please review this spec clarification at http://cr.openjdk.java.net/~weijun/8129789/webrev.00 Thanks Max

Re: [9] RFR: 8134708: Certpath validation fails to load certs and CRLs if AIA and CRLDP extensions point to LDAP resources

2015-09-02 Thread Seán Coffey
Hi Artem, I'll let the main review to other reviewers but while we're here, can you consider improving the original exception message that was seen in this issue ? In LDAPCertStore constructor : } else { throw new InvalidAlgorithmParameterException( "parame

RFR JDK-8074931: Additional tests for CertPath API

2015-09-02 Thread Frank Yuan
Hi Security developers I have a security test bug https://bugs.openjdk.java.net/browse/JDK-8074931, which is to add more coverage for CertPath and X509CertSelector in jdk repo. Would you like to review this patch http://cr.openjdk.java.net/~fyuan/8074931/webrev.00/? Your comment will be app