Looks fine to me.
Xuelei
On 9/4/2015 11:51 PM, Sean Mullan wrote:
> The JDK includes a list of required security algorithms that all
> implementations must support:
> http://docs.oracle.com/javase/8/docs/technotes/guides/security/StandardNames.html#impl
>
>
> This list is reviewed before each m
Please help with your review of this new test to check default provider
used with SecureRandom.
Bug: https://bugs.openjdk.java.net/browse/JDK-8048356
Webrev: http://cr.openjdk.java.net/~rhalade/8048356/webrev.00/
Thanks,
Rajan
Thanks for the review~
Valerie
On 9/4/2015 8:20 AM, Anthony Scarpino wrote:
Ok. The changes looks good. Thanks for looking into it and changing the bug
synopsis.
Tony
On Sep 3, 2015, at 4:25 PM, Valerie Peng wrote:
For all the JavaCritical calls, it's impossible to have the combination o
Looks good to me.
--Sean
On 09/01/2015 07:15 PM, Artem Smotrakov wrote:
Hello,
Please review this fix for 9.
Certpath validation fails to load certs and CRLs if AIA and CRLDP
extensions point to LDAP resources. This happens because LDAPCertStore
accepts only instances of LDAPCertStoreParamete
On 09/02/2015 06:23 AM, Seán Coffey wrote:
if (!u.getScheme().equalsIgnoreCase("ldap")) {
throw new InvalidAlgorithmParameterException(
"Only LDAP URIs are supported for LDAP Certore");
Let's print the scheme received!
And fix the typo: s/Certore/
The JDK includes a list of required security algorithms that all
implementations must support:
http://docs.oracle.com/javase/8/docs/technotes/guides/security/StandardNames.html#impl
This list is reviewed before each major release to check if new
algorithms should be added (or existing algorith
Ok. The changes looks good. Thanks for looking into it and changing the bug
synopsis.
Tony
> On Sep 3, 2015, at 4:25 PM, Valerie Peng wrote:
>
>
> For all the JavaCritical calls, it's impossible to have the combination of
> (bufOut==NULL && outLen!=0) as the outLen value is generated by VM
Looks good.
--Sean
On 09/01/2015 09:14 PM, Jamil Nimeh wrote:
Hi Sean, et al.,
I've updated the review to incorporate Sean's comments. Sean, I was
able to remove encodeInternal() and make it into a one-liner inside each
of the ctors, so that shrunk things down a bit more which is nice. Let
m
