Re: RFR 8044199: tests for RSA keys and key specifications

Sure, can u please send me the putback message/comment that u would like to use? And your OpenJDK user name if u have one. Thanks, Valerie On 9/8/2015 2:44 PM, Tristan Yan wrote: Hi Valerie Thank you for reviewing this, I fixed 2 points in latest webrev. Do you mind sponsor this for me if you

Re: RFR 8044199: tests for RSA keys and key specifications

Hi Valerie Thank you for reviewing this, I fixed 2 points in latest webrev. Do you mind sponsor this for me if you’re OK with this version. http://cr.openjdk.java.net/~tyan/8044199/webrev.03/ Cheers. Tristan > On Aug 28, 2015, at 2:03 PM, Va

Re: [9] Urgent RFR 8135099 "9-dev solaris builds failed on 2015-09-04"

Your fix looks fine to me. Thanks. > On 8 Sep 2015, at 21:33, Valerie Peng wrote: > > Hi, > > I need someone to help reviewing for this bug ASAP: > http://cr.openjdk.java.net/~valeriep/8135099/webrev.00/ > > The build is broken due to the compilation warning introduced in 8130875 > which slip

[9] Urgent RFR 8135099 "9-dev solaris builds failed on 2015-09-04"

Hi, I need someone to help reviewing for this bug ASAP: http://cr.openjdk.java.net/~valeriep/8135099/webrev.00/ The build is broken due to the compilation warning introduced in 8130875 which slipped through un-detected due to the "--disable-warnings-as-errors" setting in my local workspace.

Re: [9] RFR: 8134708: Certpath validation fails to load certs and CRLs if AIA and CRLDP extensions point to LDAP resources

Looks good to me Artem. Thanks for modifying! Regards, Sean. On 08/09/2015 18:00, Artem Smotrakov wrote: Hi Sean, I updated LDAPCertStore, please take a look http://cr.openjdk.java.net/~asmotrak/8134708/webrev.02/ - updated exception messages - fixed typos - added @Override annotations - rem

Re: [9] RFR: 8134708: Certpath validation fails to load certs and CRLs if AIA and CRLDP extensions point to LDAP resources

Hi Sean, I updated LDAPCertStore, please take a look http://cr.openjdk.java.net/~asmotrak/8134708/webrev.02/ - updated exception messages - fixed typos - added @Override annotations - removed unused field - removed unused imports Artem On 09/02/2015 01:23 PM, Seán Coffey wrote: Hi Artem, I'

Re: Question about X509Certificate SAN DNS Name

On 09/08/2015 08:32 PM, Sean Mullan wrote: On 09/08/2015 02:15 AM, Weijun Wang wrote: Hi Sean You closed 8016345 as a dup of 8007706, but it's about the 1st letter in a DNSName and 8007706 is about '_' inside. Should they be treated differently? Yes, probably. Please re-open the bug. Done

Re: Question about X509Certificate SAN DNS Name

On 09/08/2015 02:15 AM, Weijun Wang wrote: Hi Sean You closed 8016345 as a dup of 8007706, but it's about the 1st letter in a DNSName and 8007706 is about '_' inside. Should they be treated differently? Yes, probably. Please re-open the bug. --Sean Thanks Max On 09/08/2015 12:52 PM, k...@

Re: RFR : 8133535: Better exception messaging in Ucrypto code

On 08/09/2015 10:42, Ivan Gerasimov wrote: Thanks, Seán! On 08.09.2015 11:00, Seán Coffey wrote: With recent changes from (JDK-8132082) affecting the same ucrypto code, I've re-based my patch. Here's the new webrev : http://cr.openjdk.java.net/~coffeys/webrev.8133535.jdk9.v2/webrev/ This lo

Re: RFR : 8133535: Better exception messaging in Ucrypto code

Thanks, Seán! On 08.09.2015 11:00, Seán Coffey wrote: With recent changes from (JDK-8132082) affecting the same ucrypto code, I've re-based my patch. Here's the new webrev : http://cr.openjdk.java.net/~coffeys/webrev.8133535.jdk9.v2/webrev/ This looks very useful. NativeCipher.java: 283

Re: RFR : 8133535: Better exception messaging in Ucrypto code

With recent changes from (JDK-8132082) affecting the same ucrypto code, I've re-based my patch. Here's the new webrev : http://cr.openjdk.java.net/~coffeys/webrev.8133535.jdk9.v2/webrev/ Regards, Sean. On 24/08/2015 13:54, Seán Coffey wrote: Hoping to improve some of the exception messaging th