Re: Code Review Request 8144566, Custom HostnameVerifier disables SNI extension

2015-12-07 Thread ecki
Isnt this codepath used as a workaround for dynamically disabling SNI? Using connect(host..) instead of SSLSocket(host) was at least a common, well known workaround. Gruss Bernd -- http://bernd.eckenfels.net -Original Message- From: Bradford Wetmore To: Xuelei Fan , OpenJDK Sent: Di.

Re: Code Review Request 8144566, Custom HostnameVerifier disables SNI extension

2015-12-07 Thread Bradford Wetmore
Please see my comment in the bug. I haven't verified this, but it seems the problem might be generic to the codepath through SSLSocket, not just Https. Brad On 12/6/2015 4:32 AM, Xuelei Fan wrote: Hi, Please review the update for JDK-8144566: http://cr.openjdk.java.net/~xuelei/81

Re: Code Review Request 8141703, Test B6216082.java failed with operation timed out exception

2015-12-07 Thread Xuelei Fan
On 12/8/2015 8:11 AM, Xuelei Fan wrote: > On 12/8/2015 4:15 AM, Sean Mullan wrote: >> On 12/04/2015 09:41 AM, Xuelei Fan wrote: >>> Hi, >>> >>> Please review the test update for JDK-8141703: >>> http://cr.openjdk.java.net/~xuelei/8141703/webrev.00/ >>> >>> The test, sun/net/www/protocol/https/H

Re: Code Review Request 8141703, Test B6216082.java failed with operation timed out exception

2015-12-07 Thread Xuelei Fan
On 12/8/2015 4:15 AM, Sean Mullan wrote: > On 12/04/2015 09:41 AM, Xuelei Fan wrote: >> Hi, >> >> Please review the test update for JDK-8141703: >> http://cr.openjdk.java.net/~xuelei/8141703/webrev.00/ >> >> The test, sun/net/www/protocol/https/HttpsURLConnection/B6216082.java, >> need to start

Re: [9] RFR:8130360: Add tests to verify 3rd party security providers if they are in signed/unsigned modular JARs

2015-12-07 Thread Valerie Peng
Siba, I have just started to review this webrev and not done yet. As for your question, the java.security file in OpenJDK9 still uses the provider class names instead of provider names. Are you talking about the java.security file in Jigsaw? Which build (OpenJDK or Jigsaw) have you tested agai

Re: [9] RFR: 8140470: javax/xml/crypto/dsig/SecurityManager/XMLDSigWithSecMgr.java failed with java.security.AccessControlException

2015-12-07 Thread Sean Mullan
Looks fine to me. --Sean On 12/03/2015 09:18 AM, Artem Smotrakov wrote: I sent a wrong version of webrev, please use the following one http://cr.openjdk.java.net/~asmotrak/8140470/webrev.01/ Artem On 12/03/2015 05:10 PM, Artem Smotrakov wrote: Hello, Please review this small fix which upda

Re: Code Review Request 8141703, Test B6216082.java failed with operation timed out exception

2015-12-07 Thread Sean Mullan
On 12/04/2015 09:41 AM, Xuelei Fan wrote: Hi, Please review the test update for JDK-8141703: http://cr.openjdk.java.net/~xuelei/8141703/webrev.00/ The test, sun/net/www/protocol/https/HttpsURLConnection/B6216082.java, need to start a server and proxy, and then make https connection over the

Re: Code Review Request, 8136410 AlgorithmDecomposer is not parsing padding correctly

2015-12-07 Thread Amy Lu
On 12/7/15 8:35 PM, Xuelei Fan wrote: On 12/7/2015 8:23 PM, Amy Lu wrote: Hi, Xuelei test/sun/security/util/AlgorithmConstraints/Decomposealgorithms.java line36 private final static String PATH = System.getProperty("test.src", "."); It seems that this line could be removed. Oops, bad

Re: Code Review Request, 8136410 AlgorithmDecomposer is not parsing padding correctly

2015-12-07 Thread Xuelei Fan
On 12/7/2015 8:23 PM, Amy Lu wrote: > Hi, Xuelei > > test/sun/security/util/AlgorithmConstraints/Decomposealgorithms.java > > line36 private final static String PATH = > System.getProperty("test.src", "."); > > It seems that this line could be removed. > Oops, bad copy and past. Updated.

Re: Code Review Request, 8136410 AlgorithmDecomposer is not parsing padding correctly

2015-12-07 Thread Amy Lu
Hi, Xuelei test/sun/security/util/AlgorithmConstraints/Decomposealgorithms.java line36 private final static String PATH = System.getProperty("test.src", "."); It seems that this line could be removed. Thanks, Amy On 12/7/15 7:08 PM, Xuelei Fan wrote: Hi Brad, Please review this fix

Code Review Request, 8136410 AlgorithmDecomposer is not parsing padding correctly

2015-12-07 Thread Xuelei Fan
Hi Brad, Please review this fix for JDK-8136410: http://cr.openjdk.java.net/~xuelei/8136410/webrev.00/ AlgorithmDecomposer cannot parse "Padding" string properly as 'in' is used as a String split separator. "NoPadding" was incorrectly split as "NoPadd" and "g". This update update the slit S