Re: Design and impl review: JEP 273: DRBG-Based SecureRandom Implementations

2015-12-15 Thread Wang Weijun
Webrev updated: http://cr.openjdk.java.net/~weijun/8051408/webrev.02/ http://cr.openjdk.java.net/~weijun/8051408/webrev.02/specdiff/java/security/package-summary.html Changes: 1. DrbgParameters has a Builder now 2. No more default implementation for reseed() 3. Synchronization is now in

Re: RFR 8058778: New APIs for some keytool functions

2015-12-15 Thread Wang Weijun
Hi All Here is an updated webrev http://cr.openjdk.java.net/~weijun/8058778/webrev.05/ Spec change is at http://cr.openjdk.java.net/~weijun/8058778/webrev.05/specdiff/java/security/cert/package-summary.html These changes are made: 1. The Builder is moved into java.security.cert.X509Certi

Re: Design and impl review: JEP 273: DRBG-Based SecureRandom Implementations

2015-12-15 Thread Sean Mullan
On 12/15/2015 03:09 AM, Wang Weijun wrote: Good. But the builder will not provide default values so you will see new DrbgParameters.Builder().build().getAlgorithm() == null which means the getters still return requested values. That's fine, this is no different than what the current class

Re: RFR: 8129567 - the GCM mode parameter which is used as the initialization vector ("IV") is set to all zeros

2015-12-15 Thread Sean Mullan
This fix looks fine to me. Please add a "noreg-self" label to the bug. --Sean On 12/11/2015 05:50 AM, Bhanu Gopularam wrote: Hi all, Please review a fix for following bug: Bug Id - https://bugs.openjdk.java.net/browse/JDK-8129567 Issue – Few tests are using all zero IV for GCM parameter spec

Re: RFR 8058778: New APIs for some keytool functions

2015-12-15 Thread Sean Mullan
On 12/03/2015 09:07 PM, Wang Weijun wrote: Or if this is too much, we can at least do the X509Extension part. If CertificateRequest is needed one day, we can create a new method Builder.certificateRequest() that returns it and deprecate the current request() method. Or use certificateRequest() t

Re: Design and impl review: JEP 273: DRBG-Based SecureRandom Implementations

2015-12-15 Thread Wang Weijun
Good. But the builder will not provide default values so you will see new DrbgParameters.Builder().build().getAlgorithm() == null which means the getters still return requested values. In this case, the algorithm will only be known after it is used for a specific DRBG, for example, SHA-256 f