Re: RFR: 8129560- CKR_ARGUMENTS_BAD - private exponent needs to comply with FIPS 186-4

2015-12-18 Thread Anthony Scarpino
The problems are different. The PKCS11 error means everything in this case. Tony > On Dec 18, 2015, at 12:20 PM, Sean Mullan wrote: > > The fix looks good, although this test is already on the ProblemList due to > JDK-8074580. Do you know if that bug is caused by the same issue? The > underl

Re: Code Review Request 8049321 Support SHA256WithDSA in JSSE

2015-12-18 Thread Sean Mullan
This explanation makes sense to me and the fix looks fine. --Sean On 12/17/2015 01:51 AM, Xuelei Fan wrote: On 12/17/2015 7:52 AM, Bradford Wetmore wrote: On 12/16/2015 3:22 PM, Xuelei Fan wrote: On 12/17/2015 3:14 AM, Bradford Wetmore wrote: The change itself looks ok, but a question on t

Re: RFR: 8129560- CKR_ARGUMENTS_BAD - private exponent needs to comply with FIPS 186-4

2015-12-18 Thread Sean Mullan
The fix looks good, although this test is already on the ProblemList due to JDK-8074580. Do you know if that bug is caused by the same issue? The underlying PKCS11 error is different (maybe due to a different Solaris version?), but it looks like an identical stack trace. It would be good to als

Re: Code Review Request, 8133070 Hot lock on BulkCipher.isAvailable

2015-12-18 Thread Sean Mullan
Here are a few other other comments on the code: SSLContextImpl: - I noticed that SSLContext.init does not specify how it handles empty arrays, and you have changed the code so that an empty TrustManager array is treated like they are null - is this change in behavior a compatibility issue a