RFR 8059212: Modify sun/security/smartcardio manual regression tests so that they do not just fail if no cardreader found

2016-01-29 Thread Ivan Gerasimov
Hello! We've got a request to modify the smartcardio-related regtests so that they'll be more convenient to use. Konstantin, could you please confirm this will work for you? BUGURL: https://bugs.openjdk.java.net/browse/JDK-8059212 WEBREV: http://cr.openjdk.java.net/~igerasim/8059212/00/webrev

Re: RFR : 8038837:Add support to jarsigner for specifying timestamp hash algorithm

2016-01-29 Thread Seán Coffey
On 29/01/16 11:52, Wang Weijun wrote: On Jan 29, 2016, at 7:48 PM, Seán Coffey wrote: Since I now reference the JarSignerParameters class directly in TimestampedSigner.java, the compiler was generating a warning. I thought it might be neater to break JarSignerParameters into its own separate

Re: RFR : 8038837:Add support to jarsigner for specifying timestamp hash algorithm

2016-01-29 Thread Wang Weijun
> On Jan 29, 2016, at 7:48 PM, Seán Coffey wrote: > > Since I now reference the JarSignerParameters class directly in > TimestampedSigner.java, the compiler was generating a warning. I thought it > might be neater to break JarSignerParameters into its own separate class. Oh, yes. > Shall I

Re: RFR : 8038837:Add support to jarsigner for specifying timestamp hash algorithm

2016-01-29 Thread Seán Coffey
Since I now reference the JarSignerParameters class directly in TimestampedSigner.java, the compiler was generating a warning. I thought it might be neater to break JarSignerParameters into its own separate class. Shall I revert ? Regards, Sean. On 29/01/16 11:42, Wang Weijun wrote: Why did

Re: RFR : 8038837:Add support to jarsigner for specifying timestamp hash algorithm

2016-01-29 Thread Wang Weijun
Why did you remove the JarSignerParameters class definition inside jarsigner/Main.java? Was it duplicated somewhere else? Thanks Max > On Jan 27, 2016, at 11:09 PM, Seán Coffey wrote: > > Hi, > > I'd like to backport this enhancement to JDK 8u. It's been approved via CCC > process already.