Re: JDK 9 RFR of JDK-8151225: Mark SpecTest.java as intermittently failing

2016-03-04 Thread Sean Mullan
Looks fine to me. --Sean On 03/03/2016 05:51 PM, joe darcy wrote: Hello, The test sun/security/rsa/SpecTest.java has been observed to fail intermittently with a timeout (JDK-8137231). The observed timeouts have been for the largest key size. Until that issue is resolved, the test should be m

Re: Code Review Request 8148108 Disable Diffie-Hellman keys less than 1024 bits

2016-03-04 Thread Vincent Ryan
Your fix looks fine. Thanks. > On 4 Mar 2016, at 11:53, Xuelei Fan wrote: > > Hi, > > Please review the update for JDK-8148108: > http://cr.openjdk.java.net/~xuelei/8148108/webrev.00/ > > In this update, it is proposed to restrict the use of DH keys less than > 1024 bits in length in the SS

Code Review Request 8148108 Disable Diffie-Hellman keys less than 1024 bits

2016-03-04 Thread Xuelei Fan
Hi, Please review the update for JDK-8148108: http://cr.openjdk.java.net/~xuelei/8148108/webrev.00/ In this update, it is proposed to restrict the use of DH keys less than 1024 bits in length in the SSL/TLS/DTLS implementation in JDK 9. This restriction is applied via the Java Security proper

Re: RFR: JDK-8132942: ServerHandshaker should not throw SSLHandshakeException when CertificateStatus constructor is called with invalid arguments

2016-03-04 Thread Xuelei Fan
JDK-8132942: "The current implementation for OCSP stapling has ServerHandshaker trying to construct a CertificateStatus message, but if the arguments are invalid it throws SSLHandshakeException." In your webrev, looks like the exception get ignore before your update. I may miss something. Can y