Hi All,
Please help to review following changeset which fixes test bug for
sun/security/pkcs11/Provider/Login.sh and another similar failed test.
Bug: https://bugs.openjdk.java.net/browse/JDK-8153545
Changest: http://cr.openjdk.java.net/~amjiang/8153545/webrev.01/
Thanks,
Amanda
On 4/6/2016 6:40 PM, Wang Weijun wrote:
In my DRBG changeset, I use this style:
{@code jdk.security.provider.preferred} {@linkplain
Security#getProperty(String) security property}
I like this or
{@code jdk.security.provider.preferred} {@link
Security#getProperty(String) Security)
Brad
Approved for jdk8u-dev.
Regards,
Sean.
On 07/04/2016 15:00, Wang Weijun wrote:
The jdk8 changeset looks fine.
Thanks,
Max
On Apr 5, 2016, at 9:58 PM, Svetlana Nikandrova
wrote:
Hello,
please review and approve the backport of tests enhancement:
Original test from
https://bugs.openjdk.jav
The jdk8 changeset looks fine.
Thanks,
Max
> On Apr 5, 2016, at 9:58 PM, Svetlana Nikandrova
> wrote:
>
> Hello,
>
> please review and approve the backport of tests enhancement:
> Original test from
> https://bugs.openjdk.java.net/browse/JDK-8048147
> jdk 9 review:
> http://mail.openjdk.java
The jdk8 changeset looks fine.
Thanks,
Max
> On Apr 5, 2016, at 9:58 PM, Svetlana Nikandrova
> wrote:
>
> Hello,
>
> please review and approve the backport of tests enhancement:
> Original test from
> https://bugs.openjdk.java.net/browse/JDK-8048147
> jdk 9 review:
> http://mail.openjdk.java
Thanks. Line width adjustments made and changes pushed :
http://hg.openjdk.java.net/jdk9/dev/jdk/rev/0b18ad7184bc
Regards,
Sean.
On 06/04/2016 00:21, Xuelei Fan wrote:
Looks fine to me. Please keep each line bellow 80 characters.
Thanks,
Xuelei
On 4/6/2016 2:23 AM, Seán Coffey wrote:
Som