Hi Max,
Thanks for reviewing, you are right, "sm" should be the correct argument.
I updated the test argument and PKCS11Test, please check the new webrev:
http://cr.openjdk.java.net/~amjiang/8153545/webrev.02/
Thanks,
Amanda
On 16/4/8 上午12:28, Wang Weijun wrote:
Hi Amanda
I am not familiar wi
Maybe you can just remove the comments on 103 and 104 for now.
How did u come to the 600 timeout value? Just curious. Rest looks fine.
Thanks,
Valerie
On 4/8/2016 2:27 PM, Rajan Halade wrote:
Please help with your review of following patch to
TestAlgParameterGenerator test. It allows test more
Please help with your review of following patch to
TestAlgParameterGenerator test. It allows test more time to run, not run
in othervm, and few more trivial updates.
Bug: https://bugs.openjdk.java.net/browse/JDK-8055351
Webrev: http://cr.openjdk.java.net/~rhalade/8055351/webrev.00/
Thanks,
Raj
Hi Amanda
I am not familiar with the tests, but it looks like the 1st args argument
should be "sm" [1] to enable the security manager, not "true".
If PKCS11Test always uses args as command and optional argument(s), maybe you
should throw an exception if the command is unknown.
Thanks
Max
[1]