Re: RFR 8153545: sun/security/pkcs11/Provider/Login.sh fails on Linux

2016-04-11 Thread Wang Weijun
Hi Amanda and Artem, >>> http://cr.openjdk.java.net/~amjiang/8153545/webrev.02/ So, if "Clazz sm [policy]" is the preferred way to launch a test and we don't care about access controls outside the main(Provider) method, I'm OK with the fix. There is a KeyStore/Solaris.sh test using -Djava.secu

RFR: [9]: 8153829: javax/net/ssl/Stapling/HttpsUrlConnClient.java fails intermittently with NullPointerException

2016-04-11 Thread Rajan Halade
Please help with your review of following patch to OCSP stapling tests. HttpsUrlConnClient test failed intermittently with NPE because OCSP server was not ready. With this patch, SimpleOCSPServer indicates server ready to accept connections. Similar fix is applied to other tests in this area.

Re: RFR 8153545: sun/security/pkcs11/Provider/Login.sh fails on Linux

2016-04-11 Thread Amanda Jiang
Hi Max, Please see details in line. On 16/4/9 上午1:46, Wang Weijun wrote: Hi Amanda, This is better. On the other hand, I read the bug report and am not sure if this is the correct way to fix it. Maybe the ("java.security.SecurityPermission" "putProviderProperty.SunDeploy-MozillaJSS") permis

Re: RFR 8153545: sun/security/pkcs11/Provider/Login.sh fails on Linux

2016-04-11 Thread Artem Smotrakov
Hi Max, The policy files already have SecurityPermission "putProviderProperty.*", PKCS11Test class is quite complex. PKCS11Test needs to be run without specifying -Djava.secutity.manager. In PKCS11Test.main(), if args[0] is "sm", then the class enables a security manager right before actual

Re: RFR: [9]: 8055351: sun/security/provider/DSA/TestAlgParameterGenerator.java failed with interrupted! (timed out?)

2016-04-11 Thread Rajan Halade
On 4/8/16 3:08 PM, Valerie Peng wrote: Maybe you can just remove the comments on 103 and 104 for now. I think this comment has good information. If okay, I will like to retain it. How did u come to the 600 timeout value? Just curious. Nothing specific, it is hard to decide acceptable timeou

Re: RFR 8152205: jdk.security.provider.preferred is ambiguously documented

2016-04-11 Thread Anthony Scarpino
Ok.. I changed it to: {@code jdk.security.provider.preferred} {@link Security#getProperty(String) Security} I updated it at the same link if someone wants to double check my work http://cr.openjdk.java.net/~ascarpino/8152205/webrev/ Tony On 04/07/2016 11:42 AM, Bradford Wetmore wrote: On 4/6

Re: RFR 8140422: Add mechanism to allow non default root CAs to be not subject to algorithm restrictions

2016-04-11 Thread Anthony Scarpino
I believe I have addressed all previous comments and some changes were made to rename cacerts to jdkCA and how it works AnchorCertificates.java http://cr.openjdk.java.net/~ascarpino/8140422/webrev.03/ Tony On 02/29/2016 08:55 AM, Anthony Scarpino wrote: I need a code review of this change: h