Here are some comments for the test changes:
- Not testing key size 768?
- line 82, would be useful to indicate version here, e.g. NSS (as of
version xxx) has a hard coded ...
- line 27, 4096 should be 8192?
- format changes only? No test for (3072, 256)?
- line 50, dhp8192(8191) looks lik
OK
xuelei
> On Apr 14, 2016, at 3:24 AM, Rajan Halade wrote:
>
> The test javax/net/ssl/DTLS/CipherSuite.java has been seen to fail
> intermittently, see bug 8132320, 8130460.
>
> The test should be marked accordingly.
>
> diff -r 32bb1700f683 test/javax/net/ssl/DTLS/CipherSuite.java
> --- a
The test javax/net/ssl/DTLS/CipherSuite.java has been seen to fail
intermittently, see bug 8132320, 8130460.
The test should be marked accordingly.
diff -r 32bb1700f683 test/javax/net/ssl/DTLS/CipherSuite.java
--- a/test/javax/net/ssl/DTLS/CipherSuite.javaTue Apr 05 21:18:01
2016 +0100
+++
Thanks
Tony
On 04/12/2016 05:36 PM, Xuelei Fan wrote:
Looks fine to me.
Thanks,
Xuelei
On 4/11/2016 11:59 PM, Anthony Scarpino wrote:
Ok.. I changed it to:
{@code jdk.security.provider.preferred} {@link
Security#getProperty(String) Security}
I updated it at the same link if someone wants to
Hi Valerie,
All comments are good to me and accepted in the new webrev:
http://cr.openjdk.java.net/~xuelei/8072452/webrev.02/
On 4/13/2016 8:26 AM, Valerie Peng wrote:
> Hi Xuelei,
>
> Mostly look good, just some comments in line...
>
>
>
> line 95-100, so essentially, we will use the buil
Everything looks fine.
Thanks
Max
> On Apr 13, 2016, at 12:00 PM, Amanda Jiang wrote:
>
> Hi Max,
>
> I think it would be better to update Solaris.sh with same format of other
> scripts, please check the latest changeset:
> http://cr.openjdk.java.net/~amjiang/8153545/webrev.03/
> JPRT run is
