Re: [9] RFR: 8155575: Provider.java contains very long lines because of lambda

2016-05-20 Thread Anthony Scarpino
If breaks were not allowed, I would hope the compiler and/or tests would have failed. Tony On 05/20/2016 10:11 PM, Wang Weijun wrote: I am not sure if it's good to break inside a type name. I grep through JDK and seems nowhere else is doing it. --Max On May 20, 2016, at 11:42 PM, Svetlana

Re: [9] RFR: 8155575: Provider.java contains very long lines because of lambda

2016-05-20 Thread Wang Weijun
I am not sure if it's good to break inside a type name. I grep through JDK and seems nowhere else is doing it. --Max > On May 20, 2016, at 11:42 PM, Svetlana Nikandrova > wrote: > > Glad to hear it. Thank you! > > Svetlana > > On 20.05.2016 17:24, Anthony Scarpino wrote: >> On 05/20/2016 07

Re: RFR: 9: 8157469: DefaultProviderList.java fails with no provider class apple.security.AppleProvider found

2016-05-20 Thread Valerie Peng
Changes look fine. Thanks, Valerie On 5/20/2016 3:22 PM, Rajan Halade wrote: Please review following fix. AppleProvider is in java.base module so will not be loaded by ServiceLoader. 8157489 is filed to fix java.base/macosx/classes/module-info.java.extra. Bug: https://bugs.openjdk.java.net/

RFR: 9: 8157469: DefaultProviderList.java fails with no provider class apple.security.AppleProvider found

2016-05-20 Thread Rajan Halade
Please review following fix. AppleProvider is in java.base module so will not be loaded by ServiceLoader. 8157489 is filed to fix java.base/macosx/classes/module-info.java.extra. Bug: https://bugs.openjdk.java.net/browse/JDK-8157469 Webrev: http://cr.openjdk.java.net/~rhalade/8157469/webrev.0

Re: [9] RFR: 8155575: Provider.java contains very long lines because of lambda

2016-05-20 Thread Svetlana Nikandrova
Glad to hear it. Thank you! Svetlana On 20.05.2016 17:24, Anthony Scarpino wrote: On 05/20/2016 07:13 AM, Svetlana Nikandrova wrote: Hello, please review this code format fix for Provider.java. No code changes, just a few breaks in a really long (like > 120 characters) lines. Also examined ot

Re: [9] RFR: 8155575: Provider.java contains very long lines because of lambda

2016-05-20 Thread Anthony Scarpino
On 05/20/2016 07:13 AM, Svetlana Nikandrova wrote: Hello, please review this code format fix for Provider.java. No code changes, just a few breaks in a really long (like > 120 characters) lines. Also examined other classes in**the java.security package, but seems like Provider.java is the only o

[9] RFR: 8155575: Provider.java contains very long lines because of lambda

2016-05-20 Thread Svetlana Nikandrova
Hello, please review this code format fix for Provider.java. No code changes, just a few breaks in a really long (like > 120 characters) lines. Also examined other classes in**the java.security package, but seems like Provider.java is the only one affected. http://cr.openjdk.java.net/~snikan

Re: [9] RFR: 8157417: Some of SecureRandom test might get timed out in linux.

2016-05-20 Thread Wang Weijun
Change looks fine. Thanks Max > On May 20, 2016, at 6:11 PM, Sibabrata Sahoo > wrote: > > I missed to include one more test. > Here is the updated one: http://cr.openjdk.java.net/~ssahoo/8157417/webrev.01/ > > sun/security/provider/SeedGenerator/SeedGeneratorChoice.java might also fail > in

RE: [9] RFR: 8157417: Some of SecureRandom test might get timed out in linux.

2016-05-20 Thread Sibabrata Sahoo
I missed to include one more test. Here is the updated one: http://cr.openjdk.java.net/~ssahoo/8157417/webrev.01/ sun/security/provider/SeedGenerator/SeedGeneratorChoice.java might also fail in Linux without the fix provided. Thanks, Siba From: Sibabrata Sahoo Sent: Friday, May 20,

[9] RFR: 8157417: Some of SecureRandom test might get timed out in linux.

2016-05-20 Thread Sibabrata Sahoo
Hi, Please review the following fix for SecureRandom test which might cause timeout in Linux. webrev: http://cr.openjdk.java.net/~ssahoo/8157417/webrev.00/ JBS: https://bugs.openjdk.java.net/browse/JDK-8157417 The change includes: - Added "-Djava.security.egd=file:/dev/urand

Re: [9] RFR: 8129389: javax/net/ssl/DTLS tests fail intermittently

2016-05-20 Thread Xuelei Fan
Looks fine to me. Thanks, Xuelei On 5/20/2016 9:49 AM, Artem Smotrakov wrote: > I added more output for debugging intermittent failures in > https://bugs.openjdk.java.net/browse/JDK-8132320 > > I also updated produceHandshakePackets() to handle NEED_UNWRAP_AGAIN. > > http://cr.openjdk.java.net/