Re: RFR: 9: 8158569: ImpactOnSNI.java test failed with timeout

2016-06-08 Thread Xuelei Fan
I'm not sure this patch would work. What if throwing an exception immediately after the server ready in client side with/without this patch? There might be something wrong in the url connections of the testing. It might be worthy to add more defbug info for further evaluation. Xuelei On 6/9/201

RFR: 9: 8158569: ImpactOnSNI.java test failed with timeout

2016-06-08 Thread Rajan Halade
Please help with your review of this patch. I was not able to reproduce the timeout but thread dump indicates that test timed out on waiting for server thread to join. Server thread is kept waiting on accept if client doesn't connect. This patch allows test to throw exception, if any, on clien

Re: RFR 8062758: Update java/security/Security/ClassLoaderDeadlock/Deadlock2.sh with the removal of -Djava.ext.dirs

2016-06-08 Thread Mandy Chung
> On Jun 5, 2016, at 10:40 PM, Bhanu Gopularam > wrote: > > Hi all, > > Please review fix for following bug : > > Bug - https://bugs.openjdk.java.net/browse/JDK-8062758 > > Issue - Test java/security/Security/ClassLoaderDeadlock/Deadlock2.sh started > failing after removal of java.ext.dir

Re: [9] RFR 8157495: SHA-3 Hash algorithm performance improvements (~12x speedup)

2016-06-08 Thread Anthony Scarpino
On 06/08/2016 12:49 PM, [email protected] wrote: Hello, I would not mix performance and policy commits, but maybe those changes are related to the same task? What about Group.HmacSHA2:SunJCE is that needed as well? BTW the preferences are only set for Solaris, why are there no preference

Re: [9] RFR 8157495: SHA-3 Hash algorithm performance improvements (~12x speedup)

2016-06-08 Thread ecki
Hello, I would not mix performance and policy commits, but maybe those changes are related to the same task? What about Group.HmacSHA2:SunJCE is that needed as well? BTW the preferences are only set for Solaris, why are there no preferences on the other platforms shipped? (Or rather, why are t

[9] RFR 8157495: SHA-3 Hash algorithm performance improvements (~12x speedup)

2016-06-08 Thread Valerie Peng
Tony, Can u please help reviewing this? Most if not all of the changes here are performance enhancements suggestions from the performance team. I polished them and then updated the java.security file to add SHA-3. Webrev: http://cr.openjdk.java.net/~valeriep/8157495/webrev.00/ Thanks, Valerie

Re: [9] RFR: JDK-8158462: CipherTest should get rid of race condition

2016-06-08 Thread John Jiang
Hi Xuelei, Thanks for your comment very much! I was resolving the race condition issue on a closed JDK test, which depends on javax/net/ssl/sanity/interop/CipherTest.java. Such tests have the similar code patterns. I supposed the open JDK tests, javax/net/ssl/sanity/interop/CipherTest.java, su