Re: JDK 9 RFR of JDK-8160658: sun/security/tools/keytool/standard.sh fails on all platforms after JDK-8160415

Change looks fine. Thanks Max > On Jul 1, 2016, at 11:43 AM, Amy Lu wrote: > > Please review this simple and urgent fix for the regression introduced by > JDK-8160415. > > In this patch, an empty line added after the @key line (that introduced in > JDK-8160415) and before the comment lines t

JDK 9 RFR of JDK-8160658: sun/security/tools/keytool/standard.sh fails on all platforms after JDK-8160415

Please review this simple and urgent fix for the regression introduced by JDK-8160415. In this patch, an empty line added after the @key line (that introduced in JDK-8160415) and before the comment lines to avoid comments to be read as "key" values. bug: https://bugs.openjdk.java.net/browse/

Re: [9] RFR 8130181: Deprecate java.security.Provider(String, double, String), add Provider(String, String, String)

One tiny thing, in Provider.java: 244 *{@code getVersion()}, by filtering out the trailing optional information There should be a space between * and {. I am not sure if this is worth a clarification, that when version string is "1.2.3", we would like "1.2" being the version number and "

Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

> On Jul 1, 2016, at 9:16 AM, Valerie Peng wrote: > > Weird, I still see -provider on the link below. > http://cr.openjdk.java.net/~weijun/8130302/webrev.06/test/sun/security/tools/keytool/i18n.html.sdiff.html This is sdiff, you need to scroll to far right to see the new line. I should probabl

Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

Weird, I still see -provider on the link below. http://cr.openjdk.java.net/~weijun/8130302/webrev.06/test/sun/security/tools/keytool/i18n.html.sdiff.html If you saw differently, I need to book an urgent doc appt for my eyes... Valerie On 6/30/2016 5:40 PM, Wang Weijun wrote: Confused. http://cr

Re: [9] RFR 8130181: Deprecate java.security.Provider(String, double, String), add Provider(String, String, String)

Webrev updated with your suggestion: http://cr.openjdk.java.net/~valeriep/8130181/webrev.02/ Thanks, Valerie On 6/24/2016 5:05 PM, Wang Weijun wrote: On Jun 25, 2016, at 7:50 AM, Valerie Peng wrote: I thought about it, but as Provider object is serializable, if the field is of new type Ru

Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

> On Jul 1, 2016, at 8:20 AM, Valerie Peng wrote: > > Max, > > Please find comments in line. > > On 6/29/2016 8:18 PM, Wang Weijun wrote: >>> On Jun 30, 2016, at 9:39 AM, Valerie Peng wrote: >>> >>> Hi Max, >>> >>> Changes look fine. Just some comments/questions as below. >>> >>> >>> - li

Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

Max, Please find comments in line. On 6/29/2016 8:18 PM, Wang Weijun wrote: On Jun 30, 2016, at 9:39 AM, Valerie Peng wrote: Hi Max, Changes look fine. Just some comments/questions as below. - line 46, fix this {0} as well? I don't see {0} in keytool/Resources.java. There is one in jarsi

Re: RFR: 8154015 Apply algorithm constraints to timestamped code

Unless otherwise specified below, it was accepted.. http://cr.openjdk.java.net/~ascarpino/8154015/webrev.02/ Tony On 06/30/2016 12:00 PM, Sean Mullan wrote: Just a few comments - AlgorithmChecker.java: 79 private Date pkixdate = null; 81 private Timestamp jarTimestamp = null; These

Re: RFR: 8154015 Apply algorithm constraints to timestamped code

Just a few comments - AlgorithmChecker.java: 79 private Date pkixdate = null; 81 private Timestamp jarTimestamp = null; These can be marked final I think. 150 * {@code AlgorithmConstraints}. s/AlgorithmConstraints/Timestamp/ 153 * path for JAR files from deploy. Avoid usin

Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

Hi Sean Thanks for the comment. This exception is thrown by a helper class, which is then caught by the application class and a new localized error message including the provider name is shown to the user. Is that enough? Thanks Max > On Jun 30, 2016, at 6:59 PM, Seán Coffey wrote: > > mino

Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

On 30/06/2016 14:44, Wang Weijun wrote: Hi Sean Thanks for the comment. This exception is thrown by a helper class, which is then caught by the application class and a new localized error message including the provider name is shown to the user. Is that enough? Perfect. That should do! than

Re: RFR: Fix typographical errors in Cipher.java (JDK-8030132 and JDK-8160222)

Looks good! Similar typo is found in another file: java.security.jgss/share/classes/sun/security/jgss/spi/GSSContextSpi.java: * Return the mechanism-specific attribute associated with (@code type}. May be worth fixing it together. With kind regards, Ivan On 30.06.2016 10:39, Jamil Nimeh wro

Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

minor comment from me Max. src/java.base/share/classes/sun/security/tools/KeyStoreUtil.java 293 throw new IllegalArgumentException("No provider found"); Can you print the provider name that was being searched for in your exception ? Regards, Sean. On 30/06/2016 04:18, Wang Weijun

Re: RFR: Fix typographical errors in Cipher.java (JDK-8030132 and JDK-8160222)

Change looks fine. Thanks Max > On Jun 30, 2016, at 3:39 PM, Jamil Nimeh wrote: > > Hello all, > > This fixes a few typos in the Javadoc for Cipher.java. > > Bug: > https://bugs.openjdk.java.net/browse/JDK-8030132 > https://bugs.openjdk.java.net/browse/JDK-8160222 > > Webrev: > http://cr.ope

RFR: Fix typographical errors in Cipher.java (JDK-8030132 and JDK-8160222)

Hello all, This fixes a few typos in the Javadoc for Cipher.java. Bug: https://bugs.openjdk.java.net/browse/JDK-8030132 https://bugs.openjdk.java.net/browse/JDK-8160222 Webrev: http://cr.openjdk.java.net/~jnimeh/reviews/8030132/webrev.01/ --Jamil