Re: RFC7525 mapped to JSSE

2016-08-11 Thread Xuelei Fan
Thank you, Bernd. > For Java 8 the EC keySize < 224, can it be added? It's a plan of mine. > the fallback signalling cipher (with limited usefullness). It's a plan of mine, too. Note that JDK does not support fallback by default. DH items: JDK does not reuse DH exponents and check the received

Re: RFC7525 mapped to JSSE

2016-08-11 Thread Jamil Nimeh
Hi Bernd, For the status_request_v2 extension, both ocsp and ocsp_multi forms are supported, with preference on the latter type.  The only feature we currently don't support right now is Responder ID selection,  and that will hopefully come in a 9 update. --Jamil Original message --

Re: RFC7525 mapped to JSSE

2016-08-11 Thread Bernd Eckenfels
Hello, thank you Xuelei and Jamil. I updated the sheet and added an actual column for Java 9. There are still some todos left (mostly for digging up the detauls), but it starts to look complete now. There are only two real non-compliances (for Java 9), that is the support for HSTS in client code

Re: [9] RFR: 8162484: javax/net/ssl/Stapling/SSLSocketWithStapling.java test fails intermittently with "Address already in use" error

2016-08-11 Thread Artem Smotrakov
Hi Jamil, Thank you for review. Please see inline. On 08/10/2016 04:16 PM, Jamil Nimeh wrote: Hi Artem, I'm not an official reviewer but the solution for making the servers reject connections rather than stop and start looks pretty fair to me and seems like a nice way to simulate a downed O

Re: RFR 8162808: References to the standard JSSE cipher suite names

2016-08-11 Thread Jamil Nimeh
No problem, I'll get that fixed and remake the Javadocs to sanity check. --Jamil On 8/11/2016 1:47 AM, Xuelei Fan wrote: SSLParameters.java May be better to use the same words in the constructors SSLParameters(String[]) and SSLParameters(String[], String[]). Otherwise, looks fine to me. Thank

Re: [9] RFR 6877937: The SunJCE PBKDF2KeyImpl is requiring the MAC instance also be from SunJCE.

2016-08-11 Thread Xuelei Fan
Looks fine to me. Xuelei On 8/11/2016 7:55 PM, Vincent Ryan wrote: > Please review this change to unpin the Mac implementation from the > SunJCE provider. > Since the Mac is a private field there are no issues > regarding Clonable implementations for Mac or its MessageDigest. > Thanks. > > Bug:

[9] RFR 6877937: The SunJCE PBKDF2KeyImpl is requiring the MAC instance also be from SunJCE.

2016-08-11 Thread Vincent Ryan
Please review this change to unpin the Mac implementation from the SunJCE provider. Since the Mac is a private field there are no issues regarding Clonable implementations for Mac or its MessageDigest. Thanks. Bug: https://bugs.openjdk.java.net/browse/JDK-6977937 diff --git a/src/java.base/sha

Re: RFR 8162808: References to the standard JSSE cipher suite names

2016-08-11 Thread Xuelei Fan
SSLParameters.java May be better to use the same words in the constructors SSLParameters(String[]) and SSLParameters(String[], String[]). Otherwise, looks fine to me. Thanks, Xuelei On 8/11/2016 3:51 PM, Jamil Nimeh wrote: > Hello all, > > This javadoc-only change adds references to the JSSE ci

RFR 8162808: References to the standard JSSE cipher suite names

2016-08-11 Thread Jamil Nimeh
Hello all, This javadoc-only change adds references to the JSSE cipher suite list in the Standard Names documentation for those methods which return or can set lists of cipher suites by their String names. JBS: https://bugs.openjdk.java.net/browse/JDK-8162808 Webrev: http://cr.openjdk.java.ne

Re: [9] RFR 8161340: ProblemList.txt update for sun/security/tools/keytool/autotest.sh

2016-08-11 Thread Weijun Wang
Change looks fine. Thanks for taking care of it. I should have removed it in my fix. --Max On 8/11/2016 14:47, John Jiang wrote: Hi, Please review this patch for removing sun/security/tools/keytool/autotest.sh from ProblemList.txt. Because the associated issue JDK-8130302 has been resolved. I