Ah, yes, right.
I forgot to close the previous webrev in the browser.
With kind regards,
Ivan
On 06.09.2016 23:20, Artem Smotrakov wrote:
I think we are talking about the same "continue", but in different
webrevs :) I meant this:
http://cr.openjdk.java.net/~igerasim/8165463/01/webrev/src/jdk
I think we are talking about the same "continue", but in different
webrevs :) I meant this:
http://cr.openjdk.java.net/~igerasim/8165463/01/webrev/src/jdk.crypto.mscapi/windows/native/libsunmscapi/security.cpp.html
...
1410 if (::CertGetNameString(pCertContext,
1411
Hi Artem!
On 06.09.2016 20:45, Artem Smotrakov wrote:
Hi Ivan,
It's not really about your changes, but I am wondering if "delete []
pszNameString" should be called before "continue" in line 1414? Looks
like a potential memory leak.
I assume you mean "continue" at the line 1430, not 1414?
Y
Looks fine, but can you change the bug synopsis to something more
specific than "A few typos in javadoc"?
Thanks,
Sean
On 09/04/2016 02:04 AM, Ivan Gerasimov wrote:
Thank you Max for looking at this!
On 04.09.2016 3:37, Weijun Wang wrote:
- * three modulus sizes mentioned above. Still other
Hi Ivan,
It's not really about your changes, but I am wondering if "delete []
pszNameString" should be called before "continue" in line 1414? Looks
like a potential memory leak.
Artem
On 09/06/2016 02:54 AM, Ivan Gerasimov wrote:
Thank you Christoph for looking into this!
On 05.09.2016 2
Hi Ivan,
looks good to me - but I'm no reviewer...
Best regards
Christoph
> -Original Message-
> From: Ivan Gerasimov [mailto:[email protected]]
> Sent: Dienstag, 6. September 2016 11:55
> To: Langer, Christoph ; security-
> [email protected]
> Subject: Re: [jdk9] (S) RFR: 81
Thank you Christoph for looking into this!
On 05.09.2016 23:52, Langer, Christoph wrote:
Hi Ivan,
this looks like a good idea.
Maybe the pattern to do new (std::nothrow), then check for 0 and throw OOM is a
good candidate for a Macro which would keep the code a bit more compact?
Yes, I agr
