Sending to [email protected] as well.
Artem
On 09/07/2016 12:28 PM, Artem Smotrakov wrote:
Hello,
Please review the following patch for
sun/net/www/protocol/https/HttpsClient/ServerIdentityTest.java
The test has been observed to fail a couple of times, but it's still
not clear why
Hello,
Please review the following patch for SSLEngineBadBufferArrayAccess.java
test.
The test has been observed to fail intermittently with "Unrecognized SSL
message" error. I couldn't reproduce it, and it's currently not clear
what caused the test to fail. One guess is that something else
Hello,
Please review the following patch for
sun/net/www/protocol/https/HttpsClient/ServerIdentityTest.java
The test has been observed to fail a couple of times, but it's still not
clear why it failed because there is not much info in logs. The patch
updates the test to enable additional deb
Hi Ivan,
> > Also, I'm still wondering if you could define a little macro like:
> >
> > #define CHECKED_NEW_ARRAY(_pointer, _type, _size) \
> > _pointer = new (env) _type[_size]; \
> > if (_pointer == NULL) { \
> > __leave; \
> > }
> >
> > Then you could hav
Thank you Christoph for the comments!
On 07.09.2016 12:14, Langer, Christoph wrote:
Hi Ivan,
I agree that the code around 1414 should be rewritten and I can also see the
potential leak in loadKeysOrCertificateChains() which should definitely be
fixed.
However, I have further comments for yo
Hi Ivan,
I agree that the code around 1414 should be rewritten and I can also see the
potential leak in loadKeysOrCertificateChains() which should definitely be
fixed.
However, I have further comments for your current change:
In line 100 you should probably reduce the indent to 4 characters ins
